ci: drop codecov upload in this project #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this project, "tox -e cov" already runs pytest with `--cov-fail-under=100`, thus the coverage is always enforced to remain at 100%. Sending the coverage data to a remote service seems of little value when the coverage is already enforced at 100% when the tests are run; in fact, we probably wouldn't even reach this step if the coverage was less than 100%, since tox should have failed. It's a common source of CI flakiness, so just drop it.
rbikar
approved these changes
May 10, 2024
MichalHaluza
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this project, "tox -e cov" already runs pytest with
--cov-fail-under=100, thus the coverage is always enforced to remain at 100%.Sending the coverage data to a remote service seems of little value when the coverage is already enforced at 100% when the tests are run; in fact, we probably wouldn't even reach this step if the coverage was less than 100%, since tox should have failed.
It's a common source of CI flakiness, so just drop it.