Await dir availability while iterating StagedSource [RHELDST-25394] #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scandir in `_push_items_for_topdir` was reporting path strings as invalid arguments, presumably because they weren't yet available on the OCP environment. This commit places a `wait_exist` call on the path before doing anything with it. At the very least, we will now be warned if a path is inaccessible prior to failure.
negillett
requested review from
rohanpm,
rbikar and
chandwanitulsi
as code owners
rohanpm
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scandir in
_push_items_for_topdirwas reporting path strings as invalid arguments, presumably because they weren't yet available on the OCP environment. This commit places await_existcall on the path before doing anything with it. At the very least, we will now be warned if a path is inaccessible prior to failure.