Adds support for clouds.json to Pub Source [SPSTRAT-333] #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajreidy
requested review from
rohanpm,
rbikar and
chandwanitulsi
as code owners
rohanpm
requested changes
Aug 8, 2024
| params = {"format": "raw"} | ||
| url = os.path.join(self._url, endpoint, str(task_id), url_ending) | ||
|
|
||
| LOG.info("Requesting Pub service for %s of task: %s", url_ending, str(task_id)) | ||
| LOG.info("Requesting Pub service for JSON file from task: %s", str(task_id)) |
There was a problem hiding this comment.
If you're changing this anyway, might I suggest a log message like "Fetching AMI details from Pub task: %s" makes more sense.
Pub tasks can have JSON files attached for other reasons, so a log message of "Requesting Pub service for JSON file" is a bit vague.
jajreidy
force-pushed
the
pubsource-cloud-support
branch
2 times, most recently
from
8c879f9 to
0fc2b7c
Compare
rohanpm
reviewed
Aug 11, 2024
tests/pub/test_pub_amis.py
Outdated
| with Source.get("pub:%s" % pub_url, task_id=task_id) as source: | ||
| push_items = [item for item in source] | ||
|
|
||
| # there should be exactly one push item |
There was a problem hiding this comment.
Comment says one but next line says three. Could the false comment be fixed please?
Note, if you want to make the comment more "copy-paste resistant" you could word it like "there should be this many push items". Or even just drop the comment and comparison since the following assertion already implicitly tests the number of push items.
jajreidy
force-pushed
the
pubsource-cloud-support
branch
from
0fc2b7c to
e236db7
Compare
rohanpm
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for clouds.json to Pub source.
The new implementation will try pulling images.json from a Pub task. But if not found then it will try to pull clouds.json from a Pub task.