Fixes parsing of clouds.json file. #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…needed for the delete function downstream.
jajreidy
requested review from
rohanpm,
rbikar and
chandwanitulsi
as code owners
rohanpm
approved these changes
Aug 19, 2024
rbikar
approved these changes
Aug 20, 2024
JAVGan
approved these changes
Aug 20, 2024
|
LGTM, please merge and release whenever possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fields were found to be missing that were needed for the delete function downstream.
This is in reference to SPSTRAT-334. Testing revealed some minor issues. The MR for pubtools-marketplacesvm that provides this functionality is here: release-engineering/pubtools-marketplacesvm#27