-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(KONFLUX-6218) drop extra unpublished repository ids #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marking this as draft for now so that it doesn't get merged prematurely. Per the requirements in KONFLUX-6218, we're going to send PRs and MRs to all repos with these repository ids to update those. We'll only merge this and therefore block containers built using these repo ids until we are reasonably sure that most of those PRs and MRs have been acted on and merged. |
lcarva
reviewed
Jan 8, 2025
This was referenced Jan 9, 2025
Closed
Merged
Merged
Merged
Merged
This was referenced Jan 13, 2025
Merged
Merged
This update changes the allowed rpm repository ids to match only those found in Red Hat's repository-to-cpe.json mapping file, used by third-party scanners. In order for scanners like clair to understand what CPE a Red Hat rpm is associated with, it needs to be able to find its repository in Red Hat's published mapping file.
cdad88f
to
2c63853
Compare
It looks good to me now. |
Closed
simonbaird
added a commit
to simonbaird/enterprise-contract_ec-cli
that referenced
this pull request
Feb 11, 2025
Tweak the /etc/yum.repo.d/ubu.repo file so the rpms in the SBOM use the rpm repo id that includes the arch, for example, ubi-9-for-$basearch-baseos-rpms instead of ubi-9-baseos-rpms. This should avoid some `rpm_repos.ids_known` Conforma violations. The reason the change is needed now is due to release-engineering/rhtap-ec-policy#99 . See also https://issues.redhat.com/browse/KONFLUX-6218 . Ref: https://issues.redhat.com/browse/EC-1134
simonbaird
added a commit
to simonbaird/enterprise-contract_ec-cli
that referenced
this pull request
Feb 11, 2025
Tweak the /etc/yum.repo.d/ubu.repo file so the rpms in the SBOM use the rpm repo id that includes the arch, for example, ubi-9-for-$basearch-baseos-rpms instead of ubi-9-baseos-rpms. This should avoid some `rpm_repos.ids_known` Conforma violations. The reason the change is needed now is due to release-engineering/rhtap-ec-policy#99 . See also https://issues.redhat.com/browse/KONFLUX-6218 . Ref: https://issues.redhat.com/browse/EC-1134
simonbaird
added a commit
to simonbaird/enterprise-contract_ec-cli
that referenced
this pull request
Feb 11, 2025
Tweak the /etc/yum.repo.d/ubu.repo file so the rpms in the SBOM use the rpm repo id that includes the arch, for example, ubi-9-for-$basearch-baseos-rpms instead of ubi-9-baseos-rpms. This should avoid some `rpm_repos.ids_known` Conforma violations. The reason the change is needed now is due to release-engineering/rhtap-ec-policy#99 . See also https://issues.redhat.com/browse/KONFLUX-6218 . Ref: https://issues.redhat.com/browse/EC-1134
simonbaird
added a commit
to simonbaird/enterprise-contract_ec-cli
that referenced
this pull request
Feb 11, 2025
This is needed because of the policy change implemented in release-engineering/rhtap-ec-policy#99 See also https://issues.redhat.com/browse/KONFLUX-6218 Ref: https://issues.redhat.com/browse/EC-1134
robnester-rh
added a commit
to robnester-rh/ec-cli
that referenced
this pull request
Feb 20, 2025
Backported a change to `hack/update-rpm-lock.sh` from enterprise-contract#2311 to address policy change implemented in release-engineering/rhtap-ec-policy#99. Updated the `rpms.lock.yaml` by executing the updated script. Signed-off-by: robnester-rh <[email protected]>
brianwcook
added a commit
to brianwcook/bazel-builder
that referenced
this pull request
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update changes the allowed rpm repository ids to match only those found in Red Hat's repository-to-cpe.json mapping file, used by third-party scanners.
In order for scanners like clair to understand what CPE a Red Hat rpm is associated with, it needs to be able to find its repository in Red Hat's published mapping file.