Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(KONFLUX-6218) drop extra unpublished repository ids #99

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

ralphbean
Copy link
Member

This update changes the allowed rpm repository ids to match only those found in Red Hat's repository-to-cpe.json mapping file, used by third-party scanners.

In order for scanners like clair to understand what CPE a Red Hat rpm is associated with, it needs to be able to find its repository in Red Hat's published mapping file.

@ralphbean ralphbean requested a review from rhartman93 as a code owner January 8, 2025 20:34
@ralphbean ralphbean marked this pull request as draft January 8, 2025 20:34
@ralphbean
Copy link
Member Author

Marking this as draft for now so that it doesn't get merged prematurely. Per the requirements in KONFLUX-6218, we're going to send PRs and MRs to all repos with these repository ids to update those. We'll only merge this and therefore block containers built using these repo ids until we are reasonably sure that most of those PRs and MRs have been acted on and merged.

This was referenced Jan 9, 2025
This update changes the allowed rpm repository ids to match only those
found in Red Hat's repository-to-cpe.json mapping file, used by
third-party scanners.

In order for scanners like clair to understand what
CPE a Red Hat rpm is associated with, it needs to be
able to find its repository in Red Hat's published mapping file.
@p-rog
Copy link

p-rog commented Jan 17, 2025

It looks good to me now.

@ralphbean ralphbean mentioned this pull request Jan 17, 2025
@ralphbean ralphbean marked this pull request as ready for review January 27, 2025 13:19
@ralphbean ralphbean merged commit 27037d0 into main Feb 10, 2025
1 check passed
simonbaird added a commit to simonbaird/enterprise-contract_ec-cli that referenced this pull request Feb 11, 2025
Tweak the /etc/yum.repo.d/ubu.repo file so the rpms in the SBOM use
the rpm repo id that includes the arch, for example,
ubi-9-for-$basearch-baseos-rpms instead of ubi-9-baseos-rpms.

This should avoid some `rpm_repos.ids_known` Conforma violations.

The reason the change is needed now is due to
release-engineering/rhtap-ec-policy#99 .
See also https://issues.redhat.com/browse/KONFLUX-6218 .

Ref: https://issues.redhat.com/browse/EC-1134
simonbaird added a commit to simonbaird/enterprise-contract_ec-cli that referenced this pull request Feb 11, 2025
Tweak the /etc/yum.repo.d/ubu.repo file so the rpms in the SBOM use
the rpm repo id that includes the arch, for example,
ubi-9-for-$basearch-baseos-rpms instead of ubi-9-baseos-rpms.

This should avoid some `rpm_repos.ids_known` Conforma violations.

The reason the change is needed now is due to
release-engineering/rhtap-ec-policy#99 .
See also https://issues.redhat.com/browse/KONFLUX-6218 .

Ref: https://issues.redhat.com/browse/EC-1134
simonbaird added a commit to simonbaird/enterprise-contract_ec-cli that referenced this pull request Feb 11, 2025
Tweak the /etc/yum.repo.d/ubu.repo file so the rpms in the SBOM use
the rpm repo id that includes the arch, for example,
ubi-9-for-$basearch-baseos-rpms instead of ubi-9-baseos-rpms.

This should avoid some `rpm_repos.ids_known` Conforma violations.

The reason the change is needed now is due to
release-engineering/rhtap-ec-policy#99 .
See also https://issues.redhat.com/browse/KONFLUX-6218 .

Ref: https://issues.redhat.com/browse/EC-1134
simonbaird added a commit to simonbaird/enterprise-contract_ec-cli that referenced this pull request Feb 11, 2025
robnester-rh added a commit to robnester-rh/ec-cli that referenced this pull request Feb 20, 2025
Backported a change to `hack/update-rpm-lock.sh` from enterprise-contract#2311 to address
policy change implemented in release-engineering/rhtap-ec-policy#99.

Updated the `rpms.lock.yaml` by executing the updated script.

Signed-off-by: robnester-rh <[email protected]>
brianwcook added a commit to brianwcook/bazel-builder that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants