Fix: useBlocker stale blockerKey

[KagaKyouichirou]

Fix what causes issue#11430;

useBlocker incorrectly defines blockerKey as a state value, causing the effect that handles updating the blockerFuntion, when reacting on a new router object, to use a stale blockerKey value that has just been deleted by the cleanup function from the prior effect. This causes the already-deleted key to be re-set into the blockerFunctions global map (in router.getBlocker function), resulting multiple entries in the map, raising the quoted warning and compromising the router.

Since blockerKey is meant to track the current router object (which is reactive) and the latter effect already includes router in deps-list, blockerKey can be defined as an unreactive value wrapped by React Ref object, ensuring the effect uses the newly generated key in the same render cycle that prior effect executes.

[changeset-bot]

⚠️ No Changeset found

Latest commit: b21c955

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot]

Hi @KagaKyouichirou,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳