fix: properly handle cyclic nodes with getParentClientNodes

.changeset/early-moles-drum.md

@@ -0,0 +1,5 @@
+---
+"@react-router/dev": patch
+---
+
+properly handle cyclic imports in `getParentClientNodes` while getting unique nodes

contributors.yml

@@ -53,6 +53,7 @@
 - bhbs
 - bilalk711
 - bjohn465
+- BlankParticle
 - bmsuseluda
 - bobziroll
 - bravo-kernel

packages/react-router-dev/vite/plugin.ts

@@ -2408,10 +2408,8 @@ export const reactRouterVitePlugin: ReactRouterVitePlugin = () => {
           return;
         }
 
-        let clientModules = uniqueNodes(
-          modules.flatMap((mod) =>
-            getParentClientNodes(server.environments.client.moduleGraph, mod),
-          ),
+        let clientModules = modules.flatMap((mod) =>
+          getParentClientNodes(server.environments.client.moduleGraph, mod),
         );
 
         for (let clientModule of clientModules) {
@@ -2427,36 +2425,26 @@ export const reactRouterVitePlugin: ReactRouterVitePlugin = () => {
 function getParentClientNodes(
   clientModuleGraph: Vite.EnvironmentModuleGraph,
   module: Vite.EnvironmentModuleNode,
+  seenNodes: Set<string> = new Set(),
 ): Vite.EnvironmentModuleNode[] {
   if (!module.id) {
     return [];
   }
+  if (seenNodes.has(module.url)) {
+    return [];
+  }
+  seenNodes.add(module.url);
 
   let clientModule = clientModuleGraph.getModuleById(module.id);
   if (clientModule) {
     return [clientModule];
   }
 
   return [...module.importers].flatMap((importer) =>
-    getParentClientNodes(clientModuleGraph, importer),
+    getParentClientNodes(clientModuleGraph, importer, seenNodes),
   );
 }
 
-function uniqueNodes(
-  nodes: Vite.EnvironmentModuleNode[],
-): Vite.EnvironmentModuleNode[] {
-  let nodeUrls = new Set<string>();
-  let unique: Vite.EnvironmentModuleNode[] = [];
-  for (let node of nodes) {
-    if (nodeUrls.has(node.url)) {
-      continue;
-    }
-    nodeUrls.add(node.url);
-    unique.push(node);
-  }
-  return unique;
-}
-
 function addRefreshWrapper(
   reactRouterConfig: ResolvedReactRouterConfig,
   code: string,