Open
Conversation
Contributor
Preview Build AvailableA preview build has been created for this PR. You can install it using: pnpm install "remix-run/remix#preview/pr-11221&path:packages/remix"This preview build will be updated automatically as you push new commits. |
sergiodxa
reviewed
Mar 31, 2026
c898d76 to
2448ec5
Compare
brophdawg11
commented
Apr 1, 2026
| navigationTimeout: 5_000, | ||
| actionTimeout: 5_000, | ||
| }, | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Playwright configs can be inlined in remix-test.config.ts or you can just pass a string location of an existing playwright.config.ts file
brophdawg11
commented
Apr 1, 2026
| page.setDefaultTimeout(options.playwrightPageOptions.actionTimeout) | ||
| } | ||
|
|
||
| let coverageEnabled = options.coverage && options.browser.browserType().name() === 'chromium' |
Contributor
Author
There was a problem hiding this comment.
Only chromium supports coverage instrumentation
4e6311e to
d290f51
Compare
ed7f21f to
7a7360f
Compare
7a7360f to
1aaa16c
Compare
da2f48b to
3bf8073
Compare
This reverts commit a0fa0d6.
3bf8073 to
2f6584f
Compare
brophdawg11
commented
Apr 8, 2026
| "skipLibCheck": true, | ||
| "jsx": "react-jsx", | ||
| "jsxImportSource": "remix/component", | ||
| "preserveSymlinks": true |
Contributor
Author
There was a problem hiding this comment.
@mjackson We had to unset this option to get the playwright types to resolve properly. Do you recall why this was needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #11213Adds support for E2E testing to
remix/test.*.test.e2e.tsx?files are identified as E2E test files in the test runner and receive at.serve()method on the test context. This accepts a fetch handler, creates a server, and returns a fresh playwrightpagecontext:New config options available in
remix-test.config.ts:browser.echo- echo browser console logs back to the serverbrowser.open- open the browser during testing (headless:false) and keep it open until you exitglob.e2e- set glob that identifies an e2e test file (defaults to**/*.test.e2e.{ts,tsx})playwrightConfig- a playwright config or a path to a one on diskproject- filter tests for a single playwright project