feat!: remove built-ins polyfills on node >= 18 #42
+2,710
−4,072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4f118d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MichaelDeBoey
requested changes
Aug 30, 2023
MichaelDeBoey
force-pushed
the
native-streams
branch
from
aa1ebaa to
38c31e3
Compare
MichaelDeBoey
force-pushed
the
native-streams
branch
from
38c31e3 to
815c86a
Compare
MichaelDeBoey
force-pushed
the
native-streams
branch
from
37b9a77 to
8907c5c
Compare
There was a problem hiding this comment.
Copilot reviewed 60 out of 62 changed files in this pull request and generated no comments.
Files not reviewed (2)
- package.json: Language not supported
- packages/blob/package.json: Language not supported
Comments suppressed due to low confidence (1)
packages/blob/test/all.spec.js:1
- The removal of all test files eliminates regression tests for the native built-ins. It is recommended to add new tests verifying that Node >=18 correctly supports the built-in implementations to ensure ongoing reliability.
import { test as blobTest } from "./blob.spec.js"
MichaelDeBoey
approved these changes
Apr 7, 2025
talentlessguy
approved these changes
Apr 7, 2025
talentlessguy
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.