* use set for unique uri

* add unit tests

Author: nvanthao

internal/specs/specs.go

@@ -370,7 +370,7 @@ func LoadAdditionalSpecFromURIs(ctx context.Context, kinds *loader.TroubleshootK
 		klog.Info("No additional URIs found in all specs")
 		return
 	}
-	for _, uri := range uris {
+	for uri := range uris {
 		rawSpec, err := downloadFromHttpURL(ctx, uri, nil)
 		if err != nil {
 			klog.Warningf("failed to download spec from URI %q: %v", uri, err)

internal/specs/specs_test.go

@@ -224,3 +224,39 @@ spec:
 	require.NoError(t, err)
 	require.Len(t, specs.HostCollectorsV1Beta2, 1)
 }
+
+func TestLoadAdditionalSpecFromURIs(t *testing.T) {
+	m := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.Write([]byte(`apiVersion: troubleshoot.sh/v1beta2
+apiVersion: troubleshoot.sh/v1beta2
+kind: Preflight
+metadata:
+  name: preflight-2
+spec:
+  collectors:
+    - ceph: {}
+`))
+	}))
+	defer m.Close()
+	kinds := loader.NewTroubleshootKinds()
+	kinds.PreflightsV1Beta2 = []troubleshootv1beta2.Preflight{
+		{
+			ObjectMeta: metav1.ObjectMeta{
+				Name: "preflight-1",
+			},
+			Spec: troubleshootv1beta2.PreflightSpec{
+				Uri: m.URL,
+				Collectors: []*troubleshootv1beta2.Collect{
+					{
+						DNS: &troubleshootv1beta2.DNS{},
+					},
+				},
+			},
+		},
+	}
+
+	LoadAdditionalSpecFromURIs(context.Background(), kinds)
+	require.Len(t, kinds.PreflightsV1Beta2, 2)
+	require.Len(t, kinds.PreflightsV1Beta2[0].Spec.Collectors, 1) // ceph
+	require.Len(t, kinds.PreflightsV1Beta2[1].Spec.Collectors, 1) // dns
+}

pkg/loader/loader.go

@@ -133,8 +133,8 @@ func (kinds *TroubleshootKinds) ToYaml() (string, error) {
 
 // GetURIs dynamically extracts all the URIs from the troubleshoot kinds
 // .Spec.Uri field
-func (kinds *TroubleshootKinds) GetURIs() []string {
-	uris := []string{}
+func (kinds *TroubleshootKinds) GetURIs() map[string]bool {
+	uris := map[string]bool{}
 	obj := reflect.ValueOf(*kinds)
 
 	for i := 0; i < obj.NumField(); i++ {
@@ -154,7 +154,7 @@ func (kinds *TroubleshootKinds) GetURIs() []string {
 				continue
 			}
 
-			uris = append(uris, uriField.String())
+			uris[uriField.String()] = true
 		}
 	}
 

pkg/loader/loader_test.go

@@ -632,3 +632,33 @@ func TestLoadingEmptySpec(t *testing.T) {
 		},
 	}, kinds)
 }
+
+func TestGetURIs(t *testing.T) {
+	kinds := NewTroubleshootKinds()
+	kinds.SupportBundlesV1Beta2 = []troubleshootv1beta2.SupportBundle{
+		{
+			Spec: troubleshootv1beta2.SupportBundleSpec{
+				Uri: "https://supportbundle.com",
+			},
+		},
+	}
+	kinds.PreflightsV1Beta2 = []troubleshootv1beta2.Preflight{
+		{
+			Spec: troubleshootv1beta2.PreflightSpec{
+				Uri: "https://preflight.com",
+			},
+		},
+	}
+	kinds.CollectorsV1Beta2 = []troubleshootv1beta2.Collector{
+		{
+			Spec: troubleshootv1beta2.CollectorSpec{
+				Uri: "https://supportbundle.com",
+			},
+		},
+	}
+	uris := kinds.GetURIs()
+	assert.Equal(t, map[string]bool{
+		"https://supportbundle.com": true,
+		"https://preflight.com":     true,
+	}, uris)
+}