Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next version (primeng) #3805

Draft
wants to merge 7 commits into
base: staging
Choose a base branch
from
Draft

Next version (primeng) #3805

wants to merge 7 commits into from

Conversation

jma
Copy link
Contributor

@jma jma commented Dec 18, 2024

No description provided.

@github-actions github-actions bot added f: circulation Concerns the circulation interface or backend f: data About data model, importation, transformation, exportation of data, specific for bibliographic data developers From a developer point of view. dev: documentation About changelog, release notes, installation procedures, gh templates... f: user management f: data migration Data migration from a legacy system or a previous version labels Dec 18, 2024
@ManaDeweerdt

This comment was marked as resolved.

Sign in to view
@jma

This comment was marked as resolved.

Sign in to view
@PascalRepond

This comment was marked as outdated.

Sign in to view
@PascalRepond

This comment was marked as outdated.

Sign in to view
@PascalRepond

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the developers From a developer point of view. label Jan 28, 2025
@PascalRepond

This comment was marked as resolved.

Sign in to view
@PascalRepond

This comment was marked as resolved.

Sign in to view
@PascalRepond

This comment was marked as resolved.

Sign in to view
Garfield-fr and others added 4 commits February 12, 2025 13:12
@Garfield-fr @jma
chore(schema): use select instead of selectWithSort
8a153a9 
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@Garfield-fr @jma
chore(schema): update schemas
b010e18 
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@jma
ui: uses primeng for the frontend
0681131 
* Adds missing format alias on the the REST API.
* Adds placeholder on the contries editor.
* All document detailed view tabs is done in angular.
* Removes useless document views.
* Removes useless document jinja template filters and their corresponding tests.
* Adds layer to css styles to avoid primeng and bootstrap conflicts.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma @Garfield-fr
primeng: fix patron editor
b116a0c 
* Removes css class for the professional view.
* Adapts the main search component to the new ui version.
* Fixes several details in the patron editor.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Bertrand Zuchuat <[email protected]>
@PascalRepond

This comment was marked as resolved.

Sign in to view
@PascalRepond

This comment was marked as resolved.

Sign in to view
@PascalRepond
Copy link
Contributor

PascalRepond commented Mar 13, 2025 •
edited
Loading

Tests Angular 19

  • REP: Patron editor: there should be a default value on creation for patron.expiration_date (5 years in the future).
  • REP: No editor for acq-accounts
  • REP: Props addonRight seems not translated
  • REP: Long editors : The "Go to" section is not clearly links (see cursor on hover)
  • REP: Long editors: Display problems on screen width below lg
    image
  • REP: Document editor, contrib/genreForm/subjects: props.filters.options seem not translated
    image
  • MD: detail view : useless space for the field 'supplement to'. Ex: https://ilsdev.test.rero.ch/professional/records/documents/detail/2000532
  • MD: inventory list not filtered by login location anymore. Normal?
    • REP: Yes, this was changed a few months ago on request from clients
  • REP: The menu to add a field is too small. Also, it moves in the page when scrolling !
    image
  • MD: not redirected when we click on the field 'published in' (need to refresh). Same with 'supplement to', 'related to' etc. Instead, the record is displayed below. Ex : https://ilsdev.test.rero.ch/professional/records/documents/detail/2000094
    image

@jma @PascalRepond
chore: acquisitions
7047be6 
* Fixes poetry shell plugins.
* Removes is_canceled, send_now, exange_rate, receipt_date useless acquistions fields.
* Moves order_date from order lines to orders.
* Removes order type as it is useless.
* Uses primeng css class in the JSONSchemas.
* Adds the number of children in the acquisition acounts serializer.
* Adjusts acquistion permissions.
* Removes toggle-switch type in JSONSchemas.
* Fixes the multi-select type in JSONSchemas.
* Fixes invalid user name regular expression.
* Uniformizes placeholders.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
Co-Authored-by: Pascal Repond <[email protected]>
@github-actions github-actions bot added developers From a developer point of view. f: search f: permissions Concerns the rights management dev: fixtures Fixtures data used for ils.test and ilsdev.test labels Mar 13, 2025
@github-actions github-actions bot added f: statistics Related to the usage statistics either for pricing or for the libaries reports dev: DB Database structure (models.py) labels Mar 13, 2025
@jma @Garfield-fr
chore: upgrade to angular 19
f258c70 
Co-Authored-by: Bertrand Zuchuat <[email protected]>
Co-Authored-by: Johnny Mariéthoz <[email protected]>
@PascalRepond
chore: enhance editors UX
e7d64c8 
* Adapts certain classes in the jsonschemas for tailwind-css and for
better editors usability.
* Fixes some errors in the jsonschemas.

Co-Authored-by: Pascal Repond <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dev: DB Database structure (models.py) dev: documentation About changelog, release notes, installation procedures, gh templates... dev: fixtures Fixtures data used for ils.test and ilsdev.test developers From a developer point of view. f: circulation Concerns the circulation interface or backend f: data migration Data migration from a legacy system or a previous version f: data About data model, importation, transformation, exportation of data, specific for bibliographic data f: permissions Concerns the rights management f: search f: statistics Related to the usage statistics either for pricing or for the libaries reports f: user management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jma @ManaDeweerdt @PascalRepond @Garfield-fr