Fix Intellisense menu for Error

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Next version
 
+### API changes
+
+- `Error.makeSyntaxError` not `Error.SyntaxError.make` and for all similar error types. Makes the Intellisense menu easier to navigate. https://github.com/rescript-association/rescript-core/pull/122
+
 ## 0.4.0
 
 ### API changes

src/Core__Error.mjs

@@ -1,29 +1,11 @@
 // Generated by ReScript, PLEASE EDIT WITH CARE
 
 
-var $$EvalError = {};
-
-var $$RangeError = {};
-
-var $$ReferenceError = {};
-
-var $$SyntaxError = {};
-
-var $$TypeError = {};
-
-var $$URIError = {};
-
 function panic(msg) {
   throw new Error("Panic! " + msg + "");
 }
 
 export {
-  $$EvalError ,
-  $$RangeError ,
-  $$ReferenceError ,
-  $$SyntaxError ,
-  $$TypeError ,
-  $$URIError ,
   panic ,
 }
 /* No side effect */

src/Core__Error.res

@@ -9,30 +9,12 @@ external toException: t => exn = "%identity"
 @get external fileName: t => option<string> = "fileName"
 
 @new external make: string => t = "Error"
-
-module EvalError = {
-  @new external make: string => t = "EvalError"
-}
-
-module RangeError = {
-  @new external make: string => t = "RangeError"
-}
-
-module ReferenceError = {
-  @new external make: string => t = "ReferenceError"
-}
-
-module SyntaxError = {
-  @new external make: string => t = "SyntaxError"
-}
-
-module TypeError = {
-  @new external make: string => t = "TypeError"
-}
-
-module URIError = {
-  @new external make: string => t = "URIError"
-}
+@new external makeEvalError: string => t = "EvalError"
+@new external makeRangeError: string => t = "RangeError"
+@new external makeReferenceError: string => t = "ReferenceError"
+@new external makeSyntaxError: string => t = "SyntaxError"
+@new external makeTypeError: string => t = "TypeError"
+@new external makeURIError: string => t = "URIError"
 
 external raise: t => 'a = "%raise"
 

src/Core__Error.resi

@@ -85,63 +85,51 @@ Console.log(error->Error.name) // Logs "Error" to the console, because this is a
 @new
 external make: string => t = "Error"
 
-module EvalError: {
-  /**
+/**
   Creates a new `EvalError` with the provided `message`.
 
   See [`EvalError`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/EvalError) on MDN.
   */
-  @new
-  external make: string => t = "EvalError"
-}
-module RangeError: {
-  /**
+@new
+external makeEvalError: string => t = "EvalError"
+/**
   Creates a new `RangeError` with the provided `message`.
 
   See [`RangeError`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RangeError) on MDN.
   */
-  @new
-  external make: string => t = "RangeError"
-}
-module ReferenceError: {
-  /**
+@new
+external makeRangeError: string => t = "RangeError"
+/**
   Creates a new `ReferenceError` with the provided `message`.
 
   See [`ReferenceError`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ReferenceError) on MDN.
   */
-  @new
-  external make: string => t = "ReferenceError"
-}
-module SyntaxError: {
-  /**
+@new
+external makeReferenceError: string => t = "ReferenceError"
+/**
   Creates a new `SyntaxError` with the provided `message`.
 
   See [`SyntaxError`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SyntaxError) on MDN.
   */
-  @new
-  external make: string => t = "SyntaxError"
-}
-module TypeError: {
-  /**
+@new
+external makeSyntaxError: string => t = "SyntaxError"
+/**
   Creates a new `TypeError` with the provided `message`.
 
   See [`TypeError`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypeError) on MDN.
   */
-  @new
-  external make: string => t = "TypeError"
-}
-module URIError: {
-  /**
+@new
+external makeTypeError: string => t = "TypeError"
+/**
   Creates a new `URIError` with the provided `message`.
 
   See [`URIError`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/URIError) on MDN.
   */
-  @new
-  external make: string => t = "URIError"
-}
+@new
+external makeURIError: string => t = "URIError"
 
 /**
-Raises (throws in JavaScript language) the provided `Error.t`, which will stop execution.
+Raises (throws in JavaScript language) the provided `Error.t`, which will stop execution. See [Exceptions in ReScript](https://rescript-lang.org/docs/manual/latest/exception)
 
 ## Examples
 ```rescript

src/Core__Int.res

@@ -48,7 +48,7 @@ let rangeWithOptions = (start, end, options) => {
   let step = switch options.step {
   | None => isInverted ? -1 : 1
   | Some(0) if start !== end =>
-    Core__Error.raise(Core__Error.RangeError.make("Incorrect range arguments"))
+    Core__Error.raise(Core__Error.makeRangeError("Incorrect range arguments"))
   | Some(n) => n
   }
 

test/IntTests.res

@@ -45,7 +45,7 @@ Test.run(
   __POS_OF__("rangeWithOptions - positive, increasing, step 0"),
   catch(() => Int.rangeWithOptions(3, 6, {step: 0})),
   eq,
-  Error.RangeError.make("Incorrect range arguments"),
+  Error.makeRangeError("Incorrect range arguments"),
 )
 Test.run(
   __POS_OF__("rangeWithOptions - start == end, step 0"),
@@ -117,7 +117,7 @@ Test.run(
   __POS_OF__("rangeWithOptions - positive, increasing, step 0, inclusive"),
   catch(() => Int.rangeWithOptions(3, 6, {step: 0, inclusive: true})),
   eq,
-  Error.RangeError.make("Incorrect range arguments"),
+  Error.makeRangeError("Incorrect range arguments"),
 )
 Test.run(
   __POS_OF__("rangeWithOptions - start == end, step 0, inclusive"),

test/TempTests.res

@@ -27,7 +27,7 @@ Console.info("Error")
 Console.info("---")
 let f = () => {
   let error = Error.make("hello")
-  let typeError = Error.TypeError.make("error")
+  let typeError = Error.makeTypeError("error")
   let g = () => Error.raise(error)
   let h = () => Error.raise(typeError)
   (g, h)