-
-
Notifications
You must be signed in to change notification settings - Fork 251
Add prettier and format everything #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Deploying rescript-lang-org with
|
Latest commit: |
458d1bb
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f2322bda.rescript-lang.pages.dev |
Branch Preview URL: | https://vlk-add-prettier.rescript-lang.pages.dev |
…nto vlk/add-prettier
573e7d4
to
9cd7e09
Compare
Stick to the full defaults, I'd say. It makes ReScript stand out more as well ;-) |
Also what do you think about adding a format check in CI? Can be in another PR of course. |
I added a CI check and a pre-commit hook. I noticed we didn't have anything set up for hooks, so I added Lefthook. |
I think that's overkill. Can we rather nudge devs to have the correct formatter executed on save? |
Sure, I can remove the pre-commit hook. |
The only default I didn't use was semicolons. Not using them makes the JS look more like ReScript, which I think is nice.