Skip to content

Add prettier and format everything #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

jderochervlk
Copy link
Collaborator

The only default I didn't use was semicolons. Not using them makes the JS look more like ReScript, which I think is nice.

Copy link

cloudflare-workers-and-pages bot commented Aug 12, 2025

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 458d1bb
Status: ✅  Deploy successful!
Preview URL: https://f2322bda.rescript-lang.pages.dev
Branch Preview URL: https://vlk-add-prettier.rescript-lang.pages.dev

View logs

@fhammerschmidt
Copy link
Member

Stick to the full defaults, I'd say.
Especially for the JS examples in the markdown files.

It makes ReScript stand out more as well ;-)

@fhammerschmidt
Copy link
Member

Also what do you think about adding a format check in CI? Can be in another PR of course.

@jderochervlk
Copy link
Collaborator Author

Also what do you think about adding a format check in CI? Can be in another PR of course.

I added a CI check and a pre-commit hook. I noticed we didn't have anything set up for hooks, so I added Lefthook.

https://lefthook.dev/

@fhammerschmidt
Copy link
Member

I think that's overkill. Can we rather nudge devs to have the correct formatter executed on save?

@jderochervlk
Copy link
Collaborator Author

I think that's overkill. Can we rather nudge devs to have the correct formatter executed on save?

Sure, I can remove the pre-commit hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants