Improving the Playground

[LeoLeBras]

No description provided.

[vercel]

@LeoLeBras is attempting to deploy a commit to the ReScript Association Team on Vercel.

A member of the Team first needs to authorize it.

[tsnobip]

@LeoLeBras, thanks for your PR! I'm a bit surprised though, what browser and extensions do you use? I tested it on Firefox, Chrome and Safari on both desktop and mobile and always get white text on midnight blue which looks pretty readable to me:

Even though I really like tailwindcss (and use it in most of my projects), I don't know if we should introduce something not standard here, so we could maybe use some CSS-in-JS if we really want to introduce some custom styles. I'll try to get some feedback about it.

[tsnobip]

ok, I found it, it does get displayed in black on machines set to use the light theme, nice catch @LeoLeBras!

[tsnobip]

thanks for the catch, but the fix is actually simpler, I would rather avoid adding more technologies to this already complex beast.

If you want, you can keep your suggestion in the default code and add the suggestion I wrote.

[joshderochervlk-simplisafe]

While you're in here, I also get an issue where the dropdown to select the version of Rescript shows up as light gray text on a white background.

[fhammerschmidt]

@LeoLeBras would you update the PR with the changes that @tsnobip suggested?

[LeoLeBras]

@LeoLeBras would you update the PR with the changes that @tsnobip suggested?

I'll do it next week!

[LeoLeBras]

While you're in here, I also get an issue where the dropdown to select the version of Rescript shows up as light gray text on a white background.

Which OS and browser are you using? @joshderochervlk-simplisafe

[LeoLeBras]

This is not straightforward for a beginner to understand @@jsxConfig({ version: 4, mode: "automatic" }). I don’t think it introduces any regressions, but could you confirm that @tsnobip ?

[fhammerschmidt]

Yes, remove it.

[LeoLeBras]

works like a charm

Screen.Recording.2025-02-28.at.09.40.18.mov

[fhammerschmidt]

Nice.

[tsnobip]

looks great, thanks a lot @LeoLeBras

[tsnobip]

While you're in here, I also get an issue where the dropdown to select the version of Rescript shows up as light gray text on a white background.

I couldn't repro it either @joshderochervlk-simplisafe, we could fix that in another PR once we have more info.