Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add community blog and first blog post #973

Merged
merged 19 commits into from
Mar 4, 2025
Merged

Add community blog and first blog post #973

merged 19 commits into from
Mar 4, 2025
+252 −29

Conversation

jderochervlk
Copy link
Collaborator

  • added support for Bluesky for author socials
  • updated the community page to include Bluesky and the new community blog
  • added a community section to the blog, so now there is Official, Community, and Archived sections.

image

image

image

@vercel Vercel
Copy link

vercel bot commented Mar 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rescript-lang.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 1:44pm

@jderochervlk jderochervlk mentioned this pull request Mar 3, 2025
Closed
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 3, 2025 •
edited
Loading

Deploying rescript-lang-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 918d637
Status: ✅  Deploy successful!
Preview URL: https://8de08a12.rescript-lang.pages.dev
Branch Preview URL: https://community-blog.rescript-lang.pages.dev

View logs

fhammerschmidt
fhammerschmidt reviewed Mar 3, 2025
View reviewed changes
pages/community/overview.mdx Outdated
@@ -23,7 +23,8 @@ News are broadcasted on this site's blog, on Bluesky and X. Some extra, less imp

## Articles

- [Getting rid of your dead code in ReScript](https://dev.to/zth/getting-rid-of-your-dead-code-in-rescript-3mba)
- [Community Blog](https://rescript-lang.org/blog/community)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make that link relative?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jderochervlk
Copy link
Collaborator Author

jderochervlk commented Mar 3, 2025 •
edited
Loading 

Error Preview:
./_blogposts/2020-08-10-bucklescript-is-rebranding.mdx: Unknown href '/blog/bucklescript-8-1-new-syntax' in line 28:3

I did something to mess up the archived posts. Official and Community are working as expected. Looking into it.

Edit: Fixed! Regex is hard.

@fhammerschmidt
Copy link
Member

The previewImg is still from the release post. Do you have a different one that would fit here?

@fhammerschmidt
Copy link
Member

Also let's update the date :)

@jderochervlk
Copy link
Collaborator Author

The previewImg is still from the release post. Do you have a different one that would fit here?

What kind of images do we want? Do we even need images for every post? We could do the "generic thing from unsplash" like most folks do on other blogging sites. Other languages just seem to omit header images.

image

@fhammerschmidt
Copy link
Member

You can also just remove it, but the 11.1 image is out of place here.

@fhammerschmidt
Copy link
Member

Sorry, it seems to be only "ts", not "typescript". Then syntax highlighting should work.

Also relative links should work from the blogpost? Not sure what broke for you, but please try to make them relative.

@jderochervlk
Copy link
Collaborator Author

You can also just remove it, but the 11.1 image is out of place here.

Removed the image to use the default.

Sorry, it seems to be only "ts", not "typescript". Then syntax highlighting should work.

Fixed.

Also relative links should work from the blogpost? Not sure what broke for you, but please try to make them relative.

I pushed it up with the relative links, I'll check once the preview build completes.

@fhammerschmidt
Copy link
Member

Found a typo:
labled arguments -> labeled argmuments

@jderochervlk
Copy link
Collaborator Author

Also relative links should work from the blogpost? Not sure what broke for you, but please try to make them relative.

They are currently 404ing.

Fixed the typo.

@fhammerschmidt
Copy link
Member

Seems the vercel deployment works fine.

Only the cloudflare one does not. @cometkim

As we still publish the vercel one to rescript-lang.org we are fine for now IMO.

@cometkim
Copy link
Member

cometkim commented Mar 4, 2025

Yes, it'ok since we don't actually use the Cloudflare one yet. I'll look into it today.

@fhammerschmidt fhammerschmidt merged commit df7a9ac into master Mar 4, 2025
4 checks passed
@fhammerschmidt fhammerschmidt deleted the community-blog branch March 4, 2025 13:59
fhammerschmidt added a commit that referenced this pull request Mar 4, 2025
@fhammerschmidt
Revert "Add community blog and first blog post (#973)"
bd1a6e0 
This reverts commit df7a9ac.
@fhammerschmidt fhammerschmidt mentioned this pull request Mar 4, 2025
Merged
fhammerschmidt added a commit that referenced this pull request Mar 4, 2025
@fhammerschmidt
Revert "Add community blog and first blog post (#973)" (#976)
4774d48 
This reverts commit df7a9ac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhammerschmidt fhammerschmidt fhammerschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jderochervlk @fhammerschmidt @cometkim