Use bsc.exe
to figure out rescript version
#1083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1079
I'm also in a little weird position where I use
nvm
on Mac, and somehow node is not always on my path anymore. This worked in the past, but is somehow broken for me, so I took a look in how I can get the LSP server working without depending on Node being present.Turns out, the only thing I bump into is the initial rescript version call.
That will run
node_modules/.bin/rescript
which in the latest alpha hasFor all the other stuff where we shell out to
bsc
,rescript-editor-analysis
, we target the platform specific executable.So, in this PR, I'm changing the version check to do the same.
bsc.exe -v
also produces the version we are after, prepended withReScript
.