tools: add source field (Loc)
#900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing ReScript bindings here, right? Should add them to the ReScript files. |
|
ReScript files updated! |
zth
reviewed
Jan 27, 2024
tools/src/tools.ml
Outdated
Comment on lines
286
to
304
| let findRelativePath ~rootPath ~path = | ||
| let open Filename in | ||
| let realPath = | ||
| match rootPath = "." with | ||
| | true -> Sys.getcwd () | ||
| | false -> | ||
| if is_relative rootPath then concat (Sys.getcwd ()) rootPath else rootPath | ||
| in | ||
| let rec loop dirPath acc = | ||
| match dirname dirPath = realPath with | ||
| | true -> basename dirPath :: acc |> String.concat "/" | ||
| | false -> ( | ||
| match dirPath with | ||
| | "/" -> failwith "Failed to find relative path of package" | ||
| | "." -> path | ||
| | _ -> loop (dirname dirPath) (basename dirPath :: acc)) | ||
| in | ||
|
|
||
| loop path [] |
There was a problem hiding this comment.
No built in fn that does this I take it...?
There was a problem hiding this comment.
thank you. Found in Analysis.Files.realpath
There was a problem hiding this comment.
Great! Now we just need to figure out the tests for Windows. Paths being different is obviously expected.
zth
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit location of type/value/module
In general, you can run the command from anywhere. The
filepathproperty is relative to the package root.