Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions: upgrade some actions to v4 to fix deprecation warnings #6594

Closed
wants to merge 3 commits into from
Closed

Github actions: upgrade some actions to v4 to fix deprecation warnings #6594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0764b28
Use OCaml 4.14.1 (+ Alpine 3.19 container) for CI build
cknitt Feb 1, 2024
e4286ce
Update CHANGELOG
cknitt Feb 2, 2024
56a02fb
Github actions: upgrade some actions to v4 to fix deprecation warnings
cknitt Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
runs-on: ${{matrix.os}}

container:
image: ghcr.io/rescript-lang/rescript-ci-build:v1.1.0
image: ghcr.io/rescript-lang/rescript-ci-build:v1.2.0

steps:
# See https://github.com/actions/runner/issues/801#issuecomment-1374967227.
Expand All @@ -43,7 +43,7 @@ jobs:
run: sed -i "s:ID=alpine:ID=NotpineForGHA:" /etc/os-release

- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Build compiler binaries
run: opam exec -- dune build --display quiet --profile static
Expand All @@ -55,7 +55,7 @@ jobs:
run: python3 configure.py --bootstrap --verbose

- name: "Upload artifacts"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: static-binaries-linux-${{runner.arch}}
path: |
Expand All @@ -72,7 +72,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Download static linux binaries
if: runner.os == 'Linux'
Expand All @@ -87,7 +87,7 @@ jobs:
chmod +x _build/install/default/bin/*

- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16

Expand All @@ -98,7 +98,7 @@ jobs:
run: node .github/workflows/get_artifact_info.js

- name: "Upload artifacts: binaries"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ env.artifact_name }}
path: ${{ env.artifact_path }}
Expand All @@ -115,7 +115,7 @@ jobs:
ubuntu-latest,
windows-latest,
]
ocaml_compiler: [4.14.0]
ocaml_compiler: [4.14.1]

runs-on: ${{matrix.os}}

Expand All @@ -130,7 +130,7 @@ jobs:
git config --global core.eol lf

- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 2 # to be able to check for changes in subfolder jscomp/syntax later

Expand Down Expand Up @@ -173,7 +173,7 @@ jobs:
run: opam exec -- dune build --display quiet --profile release

- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16

Expand Down Expand Up @@ -262,14 +262,14 @@ jobs:
run: node .github/workflows/get_artifact_info.js

- name: "Upload artifacts: binaries"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ env.artifact_name }}
path: ${{ env.artifact_path }}

- name: "Upload artifacts: lib/ocaml"
if: runner.os == 'Linux'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: lib-ocaml
path: lib/ocaml
Expand All @@ -280,10 +280,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16

Expand Down Expand Up @@ -314,7 +314,7 @@ jobs:
run: node .github/workflows/prepare_package_upload.js ${{ github.event.pull_request.head.sha }}

- name: "Upload artifact: npm packages"
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: npm-packages
path: |
Expand All @@ -341,10 +341,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16

Expand Down Expand Up @@ -373,10 +373,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16
registry-url: https://registry.npmjs.org # Needed to make auth work for publishing
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@

- Fix issue with async and newtype in uncurried mode. https://github.com/rescript-lang/rescript-compiler/pull/6601

#### :house: Internal

- Use OCaml 4.14.1 (+ Alpine 3.19 container) for CI build. https://github.com/rescript-lang/rescript-compiler/pull/6600

# 11.1.0-rc.1

#### :rocket: New Feature
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Make sure you have [opam](https://opam.ocaml.org/doc/Install.html) installed on
opam init

# Any recent OCaml version works as a development compiler
opam switch create 4.14.0 # can also create local switch with opam switch create . 4.14.0
opam switch create 4.14.1 # can also create local switch with opam switch create . 4.14.1

# Install dev dependencies from OPAM
opam install . --deps-only
Expand Down