Drop bsconfig.json support entirely
#6781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess that's fine for ReScript 12. What do you think @zth? |
|
Yes, totally fine imo. |
cknitt
approved these changes
May 26, 2024
|
forgot the gentype 😅 let me fix quick |
but now we have another circular dependency 😅 need to wait the `@rescript/react` release See rescript-lang/rescript-react#115
|
Need to wait rescript-lang/rescript-react#115 to be released 😅 |
|
Is it better to ship this later, maybe in v12.x? |
|
Yeah maybe that's better. That's our thinking with keeping some of the Js namespace around as well for v12, so it's along the same lines. |
cometkim
changed the title
bsconfig.json support entirely
cometkim
changed the title
bsconfig.json support entirelybsconfig.json support entirely
5 tasks
|
I'll reopen this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.