Stdlib namespace for Core modules #7285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
force-pushed
the
stdlib-namespace
branch
3 times, most recently
from
af47499 to
5c0a664
Compare
cknitt
commented
Feb 8, 2025
tests/analysis_tests/tests/src/expected/CompletionTypeT.res.txt
Outdated
Show resolved
Hide resolved
tests/analysis_tests/tests/src/expected/CompletionTypeT.res.txt
Outdated
Show resolved
Hide resolved
cknitt
force-pushed
the
stdlib-namespace
branch
from
5c0a664 to
91818bb
Compare
cknitt
commented
Feb 8, 2025
cknitt
force-pushed
the
stdlib-namespace
branch
4 times, most recently
from
42038a5 to
93beba5
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 295116a | Previous: 5d9c682 | Ratio |
|---|---|---|---|
Parse RedBlackTree.res - time/run |
1.8592550133333332 ms |
1.3523686533333334 ms |
1.37 |
Print RedBlackTree.res - time/run |
3.06102946 ms |
1.98472278 ms |
1.54 |
Print RedBlackTreeNoComments.res - time/run |
2.7996436466666665 ms |
1.8453905533333332 ms |
1.52 |
Parse Napkinscript.res - time/run |
61.12412062666667 ms |
42.23872597333333 ms |
1.45 |
Print Napkinscript.res - time/run |
99.01746072666666 ms |
60.21953604666667 ms |
1.64 |
Parse HeroGraphic.res - time/run |
7.570664999999999 ms |
5.70670238 ms |
1.33 |
Print HeroGraphic.res - time/run |
12.692955446666666 ms |
8.188623 ms |
1.55 |
This comment was automatically generated by workflow using github-action-benchmark.
cknitt
force-pushed
the
stdlib-namespace
branch
2 times, most recently
from
dab5123 to
8ed70db
Compare
cknitt
force-pushed
the
stdlib-namespace
branch
12 times, most recently
from
d296a89 to
b574afe
Compare
zth
force-pushed
the
stdlib-namespace
branch
from
295116a to
b07e0b7
Compare
Merged
cknitt
force-pushed
the
stdlib-namespace
branch
from
95b58cd to
064a47e
Compare
cknitt
force-pushed
the
stdlib-namespace
branch
2 times, most recently
from
a7ac9cc to
6e401c4
Compare
cknitt
force-pushed
the
stdlib-namespace
branch
from
37c578e to
9602a66
Compare
cknitt
changed the title
zth
reviewed
Feb 17, 2025
| {"contents": {"kind": "markdown", "value": "```rescript\n('a => 'b, List.t<'a>) => List.t<'b>\n```\n\n---\n\n```\n \n```\n```rescript\ntype List.t<'a> = list<'a>\n```\nGo to: [Type definition](command:rescript-vscode.go_to_location?%5B%22List.res%22%2C34%2C0%5D)\n"}} | ||
| {"contents": {"kind": "markdown", "value": "```rescript\n('a => 'b, Stdlib.List.t<'a>) => Stdlib.List.t<'b>\n```\n\n---\n\n```\n \n```\n```rescript\ntype Stdlib.List.t<'a> = list<'a>\n```\nGo to: [Type definition](command:rescript-vscode.go_to_location?%5B%22Stdlib_List.resi%22%2C34%2C0%5D)\n"}} |
There was a problem hiding this comment.
This change is something we want to eventually figure out/deal with. But I'll make a separate issue for it, since it's not a show stopper to get this merged.
zth
reviewed
Feb 17, 2025
Comment on lines
-117
to
+119
| "detail": "(array<'a>, Symbol.t) => option<'b>", | ||
| "detail": "(array<'a>, Stdlib_Symbol.t) => option<'b>", |
There was a problem hiding this comment.
Same here, will address in separate issue.
cknitt
force-pushed
the
stdlib-namespace
branch
from
d6fff7f to
fa2051f
Compare
zth
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid name clashes with user modules as observed in #7126 (comment).