Fix issue with untagged variants and object when null is one case. #7303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 6788385 | Previous: 80744a5 | Ratio |
|---|---|---|---|
Print HeroGraphic.res - time/run |
12.935322933333332 ms |
12.308145193333333 ms |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
Fixes #7289 The check emitted for case `Object` was simply `type of ... === "object"`, though that is insufficient when the variant has one case corresponding to `null`. Now we check if such a variant case exists, and emit `... != null` in addition.
cristianoc
force-pushed
the
untagged-variants-null
branch
from
fd6e41e to
c4ba210
Compare
|
This would be good to get into a v11 release too. |
|
This issue does not occur in v11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7289
The check emitted for case
Objectwas simplytype of ... === "object", though that is insufficient when the variant has one case corresponding tonull. Now we check if such a variant case exists, and emit... != nullin addition.