Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify JSON.Decode implementation #7304

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Simplify JSON.Decode implementation #7304

merged 2 commits into from
Feb 18, 2025

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Feb 17, 2025

Much less magic! 🙂

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: 269b005 Previous: 80744a5 Ratio
Print HeroGraphic.res - time/run 13.25889772 ms 12.308145193333333 ms 1.08

This comment was automatically generated by workflow using github-action-benchmark.

@cknitt cknitt requested review from zth and cristianoc February 17, 2025 20:18
@cknitt cknitt merged commit 0fda872 into master Feb 18, 2025
20 checks passed
@cknitt cknitt deleted the json-decode branch February 18, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants