Global per-project configuration of autocomplete #7330
Conversation
| @@ -415,6 +415,7 @@ ContextPath Value[String, split](Nolabel, Nolabel) | |||
| ContextPath Value[String, split] | |||
| Path String.split | |||
| Path Stdlib.Array.ma | |||
| Path ArrayUtils.ma | |||
There was a problem hiding this comment.
This change in output is fine.
There was a problem hiding this comment.
Notice how both "configured" global completions work in this file.
tests/analysis_tests/tests/src/expected/CompletionTypeT.res.txt
Outdated
Show resolved
Hide resolved
analysis/src/CompletionBackEnd.ml
Outdated
| @@ -1135,6 +1135,32 @@ and getCompletionsForContextPath ~debug ~full ~opens ~rawOpens ~pos ~env ~exact | |||
| | _ -> false | |||
| else true) | |||
| in | |||
|
|
|||
| (* TODO(config-complete-builtins) This config and config resolution should come from `package` instead. *) | |||
There was a problem hiding this comment.
package here is under full.package I believe, and is a concept used throughout the analysis. It represents the information needed from rescript.json.
analysis/src/CompletionBackEnd.ml
Outdated
| (* TODO(config-complete-builtins) This config and config resolution should come from `package` instead. *) | ||
| let pretendPackageBuiltinsConfig = | ||
| Misc.StringMap.of_list | ||
| [("array", ["ArrayUtils"]); ("Fastify.t", ["FastifyExt"])] |
There was a problem hiding this comment.
This is an array of identifiers because you could configure several modules to complete from.
The format should be Path.To.Module. These examples are all single module paths, but could've just as easily been for example Utils.Array instead of ArrayUtils. Might be good adding test cases for that as well.
fhammerschmidt
force-pushed
the
global-completion-config
branch
from
2b456de to
3b228c5
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: 0051096 | Previous: 3f06468 | Ratio |
|---|---|---|---|
Print HeroGraphic.res - time/run |
26.637155366666665 ms |
7.840572506666666 ms |
3.40 |
Print HeroGraphic.res - allocs/run |
10571467 words |
1396448 words |
7.57 |
This comment was automatically generated by workflow using github-action-benchmark.
zth
force-pushed
the
global-completion-config
branch
from
0051096 to
389c4cc
Compare
tests/analysis_tests/tests/src/expected/CompletionExpressions.res.txt
Outdated
Show resolved
Hide resolved
zth
changed the title
cc @fhammerschmidt
This hard codes a setup that works for doing global configuration of autocomplete. What's needed here is to connect the dots:
rescript.json, and read from that in the analysis toolingrescript.json<12as wellEDIT: I think this is ready to go now @fhammerschmidt ? I made some final edits.