Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Schedule, cancel and update email #38

Merged
merged 4 commits into from
Aug 14, 2024
Merged

feat: Schedule, cancel and update email #38

merged 4 commits into from
Aug 14, 2024

Conversation

drish
Copy link
Collaborator

@drish drish commented Aug 13, 2024 •
edited
Loading

  • Added the ScheduledAt attribute to the SendParams type
  • Added the following new methods to the Emails module:
	UpdateWithContext(ctx context.Context, params *UpdateEmailRequest) (*UpdateEmailResponse, error)
	Update(params *UpdateEmailRequest) (*UpdateEmailResponse, error)
	CancelWithContext(ctx context.Context, emailID string) (*CancelScheduledEmailResponse, error)
	Cancel(emailID string) (*CancelScheduledEmailResponse, error)
  • Added scheduled_email.go example

@drish drish marked this pull request as ready for review August 13, 2024 14:13
felipevolpone
felipevolpone reviewed Aug 14, 2024
View reviewed changes
felipevolpone
felipevolpone approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@felipevolpone felipevolpone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment, but great job 🙌

felipevolpone
felipevolpone reviewed Aug 14, 2024
View reviewed changes
emails.go
@@ -88,6 +107,10 @@ func (a *Attachment) MarshalJSON() ([]byte, error) {
}

type EmailsSvc interface {
CancelWithContext(ctx context.Context, emailID string) (*CancelScheduledEmailResponse, error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's nice that we are providing the methods with and without context 👍

@drish @felipevolpone
Update emails.go
93b5912 
Co-authored-by: Felipe Volpone <[email protected]>
@drish drish merged commit 37ced1d into main Aug 14, 2024
3 checks passed
@drish drish deleted the feat/scheduled-emails branch August 14, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipevolpone felipevolpone felipevolpone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drish @felipevolpone