-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Support creation of BOE against more than one purchase invoice #2932
base: develop
Are you sure you want to change the base?
Conversation
Sanket322
commented
Jan 8, 2025
•
edited by huly-for-github
bot
Loading
edited by huly-for-github
bot
- closes: Support creation of BOE against more than one purchase invoice #2886
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2932 +/- ##
===========================================
- Coverage 57.39% 57.30% -0.10%
===========================================
Files 126 127 +1
Lines 12678 12748 +70
===========================================
+ Hits 7277 7305 +28
- Misses 5401 5443 +42
|
india_compliance/gst_india/doctype/bill_of_entry/bill_of_entry.py
Outdated
Show resolved
Hide resolved
india_compliance/gst_india/doctype/purchase_reconciliation_tool/__init__.py
Outdated
Show resolved
Hide resolved
5000dca
to
d2f101b
Compare
@@ -401,9 +401,11 @@ class BillOfEntry(IneligibleITC): | |||
def update_valuation_rate(self): | |||
# Update fixed assets | |||
asset_items = self.doc.get_asset_items() | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To validate
india_compliance/gst_india/doctype/boe_purchase_invoice/boe_purchase_invoice.json
Outdated
Show resolved
Hide resolved
@@ -35,6 +35,9 @@ | |||
"accounting_dimensions_section", | |||
"cost_center", | |||
"dimension_col_break", | |||
"section_break_bira", | |||
"purchase_invoices", | |||
"get_items_from_purchase_invoice", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_items_from button
india_compliance/gst_india/doctype/bill_of_entry/bill_of_entry.js
Outdated
Show resolved
Hide resolved
india_compliance/gst_india/doctype/bill_of_entry/bill_of_entry.py
Outdated
Show resolved
Hide resolved
purchase_invoices = frappe.get_all( | ||
"Purchase Invoice", | ||
filters={"name": ["in", pi_names]}, | ||
fields=["docstatus", "gst_category", "name"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
validate same company and gstin across invoices