Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support creation of BOE against more than one purchase invoice #2932

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

Sanket322
Copy link
Contributor

@Sanket322 Sanket322 commented Jan 8, 2025

@Sanket322 Sanket322 marked this pull request as draft January 8, 2025 06:10
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 59.30233% with 35 lines in your changes missing coverage. Please review.

Project coverage is 57.30%. Comparing base (4eb8ca3) to head (8e6ccbd).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
...e/gst_india/doctype/bill_of_entry/bill_of_entry.py 58.75% 33 Missing ⚠️
...compliance/gst_india/overrides/purchase_invoice.py 0.00% 1 Missing ⚠️
...ort/bill_of_entry_summary/bill_of_entry_summary.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2932      +/-   ##
===========================================
- Coverage    57.39%   57.30%   -0.10%     
===========================================
  Files          126      127       +1     
  Lines        12678    12748      +70     
===========================================
+ Hits          7277     7305      +28     
- Misses        5401     5443      +42     
Files with missing lines Coverage Δ
...ctype/boe_purchase_invoice/boe_purchase_invoice.py 100.00% <100.00%> (ø)
...a/doctype/purchase_reconciliation_tool/__init__.py 50.20% <ø> (ø)
...a_compliance/gst_india/overrides/ineligible_itc.py 95.81% <100.00%> (+0.01%) ⬆️
...compliance/gst_india/overrides/purchase_invoice.py 67.69% <0.00%> (-0.53%) ⬇️
...ort/bill_of_entry_summary/bill_of_entry_summary.py 0.00% <0.00%> (ø)
...e/gst_india/doctype/bill_of_entry/bill_of_entry.py 75.92% <58.75%> (-2.53%) ⬇️

... and 6 files with indirect coverage changes

Impacted file tree graph

@Sanket322 Sanket322 marked this pull request as ready for review January 10, 2025 11:37
@Sanket322 Sanket322 requested a review from vorasmit January 10, 2025 11:37
@vorasmit vorasmit added the p1 label Jan 10, 2025
@@ -401,9 +401,11 @@ class BillOfEntry(IneligibleITC):
def update_valuation_rate(self):
# Update fixed assets
asset_items = self.doc.get_asset_items()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To validate

@@ -35,6 +35,9 @@
"accounting_dimensions_section",
"cost_center",
"dimension_col_break",
"section_break_bira",
"purchase_invoices",
"get_items_from_purchase_invoice",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_items_from button

purchase_invoices = frappe.get_all(
"Purchase Invoice",
filters={"name": ["in", pi_names]},
fields=["docstatus", "gst_category", "name"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validate same company and gstin across invoices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support creation of BOE against more than one purchase invoice
3 participants