Skip to content

Pull in everything mistakenly pushed to main #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 13, 2023
Merged

Pull in everything mistakenly pushed to main #60

merged 12 commits into from
Jul 13, 2023

Conversation

danhunsaker
Copy link
Member

New commits should go to develop. That includes PRs.

danhunsaker and others added 11 commits December 20, 2019 15:33
Added urlencoding and base64encoding for redis password
changed hashing to encoding as suggested
Support Redis Password Encoding
Only ping redis if Worker is unpaused
* CI: Move to GitHub actions

* lib: fix issues found by PHPStan

* CI: Install redis for phpunit

* CI: remove unused code coverage providers

* Add PHPCS config for PSR12-with-tabs

Co-authored-by: Dan Hunsaker <[email protected]>
* Clean up unit test output

- Use a mocked logger to remove output spam
- Fix phpunit deprecation warnings

* Migrate phpunit config file to newer format

* Use phpunit 5.x for github actions

The default is phpunit 9.x and that doesn't find any tests.
@pprkut
Copy link
Collaborator

pprkut commented Feb 5, 2022

Oh sorry! I somehow was under the impression develop had been a temporary integration branch for all the PRs from the old repo. My bad! Should I recreate the still open pull requests?

EDIT: Just saw that isn't needed. I can change the target branch on the pull requests, just need to wait until this one is merged

@danhunsaker
Copy link
Member Author

danhunsaker commented Feb 5, 2022

Yeah, i just needed to be paying more attention when merging stuff. 😅 Also, i had main set as the default, so all PRs went against it by default anyway, so I needed to fix that, too.

@danhunsaker danhunsaker requested a review from a team February 5, 2022 08:08
@pprkut
Copy link
Collaborator

pprkut commented Nov 22, 2022

@danhunsaker ping 🙂

@pprkut
Copy link
Collaborator

pprkut commented May 31, 2023

@danhunsaker Is there any way we could move this along? The way things are now this repo looks as abandoned as the previous one, which would be a shame 😕

I created a branch now in my repo that combines all the changes I need at work, but that's not really a long-term solution. There's some other people who mentioned they forked it already too. I would hate to see the community splinter any further.

@pprkut
Copy link
Collaborator

pprkut commented Jun 30, 2023

@danhunsaker Any chance you could add me to the team? Then I could start merging some of the open reviews. I really want to try everything to keep this repo alive rather than creating a new fork.

@danhunsaker
Copy link
Member Author

Been waiting for an approval from someone on the team, but it hasn't happened... Trying to work around the requirement now.

@danhunsaker danhunsaker merged commit 2a6a4a5 into develop Jul 13, 2023
@pprkut pprkut mentioned this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants