-
Notifications
You must be signed in to change notification settings - Fork 78
Pull in everything mistakenly pushed to main #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added urlencoding and base64encoding for redis password
changed hashing to encoding as suggested
Support Redis Password Encoding
Only ping redis if Worker is unpaused
* CI: Move to GitHub actions * lib: fix issues found by PHPStan * CI: Install redis for phpunit * CI: remove unused code coverage providers * Add PHPCS config for PSR12-with-tabs Co-authored-by: Dan Hunsaker <[email protected]>
* Clean up unit test output - Use a mocked logger to remove output spam - Fix phpunit deprecation warnings * Migrate phpunit config file to newer format * Use phpunit 5.x for github actions The default is phpunit 9.x and that doesn't find any tests.
Oh sorry! I somehow was under the impression EDIT: Just saw that isn't needed. I can change the target branch on the pull requests, just need to wait until this one is merged |
Yeah, i just needed to be paying more attention when merging stuff. 😅 Also, i had |
@danhunsaker ping 🙂 |
@danhunsaker Is there any way we could move this along? The way things are now this repo looks as abandoned as the previous one, which would be a shame 😕 I created a branch now in my repo that combines all the changes I need at work, but that's not really a long-term solution. There's some other people who mentioned they forked it already too. I would hate to see the community splinter any further. |
@danhunsaker Any chance you could add me to the team? Then I could start merging some of the open reviews. I really want to try everything to keep this repo alive rather than creating a new fork. |
Been waiting for an approval from someone on the team, but it hasn't happened... Trying to work around the requirement now. |
New commits should go to
develop
. That includes PRs.