Add Java food ordering example #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gvdongen
commented
Jan 4, 2024
gvdongen
commented
- The food ordering examples as presented at Current 2023, implemented with the Java SDK.
- Docker compose set up to run the example
There was a problem hiding this comment.
One comment I have is that the POJOs you used for state, awakeables and location are all coded with different styles: some have mutable fields, some are private and others are public.
I suggest to just adopt a single style, to make that code simpler to follow. One style I usually follow myself is to create immutable pojos, with private final fields, and eventually make some fields mutable with setters if I need to. For that, you only need an annotated constructor and the getters, e.g. like this: https://github.com/restatedev/notebook-demo/pull/6/files#diff-a373f8bd90769e63096ed7b18dfdb98a8fe19ed3df9a8bcf08aefe3d2296c010R7
java/food-ordering/app/restate-app/src/main/java/dev/restate/sdk/examples/DeliveryManager.java
Outdated
Show resolved
Hide resolved
java/food-ordering/app/restate-app/src/main/java/dev/restate/sdk/examples/DeliveryManager.java
Outdated
Show resolved
Hide resolved
java/food-ordering/app/restate-app/src/main/java/dev/restate/sdk/examples/DeliveryManager.java
Outdated
Show resolved
Hide resolved
...d-ordering/app/restate-app/src/main/java/dev/restate/sdk/examples/DriverDeliveryMatcher.java
Outdated
Show resolved
Hide resolved
...d-ordering/app/restate-app/src/main/java/dev/restate/sdk/examples/DriverDeliveryMatcher.java
Outdated
Show resolved
Hide resolved
...pp/restate-app/src/main/java/dev/restate/sdk/examples/external/DriverMobileAppSimulator.java
Outdated
Show resolved
Hide resolved
...dering/app/restate-app/src/main/java/dev/restate/sdk/examples/types/DeliveryInformation.java
Outdated
Show resolved
Hide resolved
...-ordering/app/restate-app/src/main/java/dev/restate/sdk/examples/types/AssignedDelivery.java
Outdated
Show resolved
Hide resolved
java/food-ordering/app/restate-app/src/main/java/dev/restate/sdk/examples/types/Location.java
Outdated
Show resolved
Hide resolved
…dk/examples/DeliveryManager.java Co-authored-by: Francesco Guardiani <[email protected]>
…dk/examples/DriverDeliveryMatcher.java Co-authored-by: Francesco Guardiani <[email protected]>
…dk/examples/DriverDeliveryMatcher.java Co-authored-by: Francesco Guardiani <[email protected]>
…dk/examples/DriverDigitalTwin.java Co-authored-by: Francesco Guardiani <[email protected]>
…dk/examples/external/DriverMobileAppSimulator.java Co-authored-by: Francesco Guardiani <[email protected]>
…dk/examples/DriverDigitalTwin.java Co-authored-by: Francesco Guardiani <[email protected]>
…dk/examples/DriverDigitalTwin.java Co-authored-by: Francesco Guardiani <[email protected]>
…dk/examples/OrderStatusService.java Co-authored-by: Francesco Guardiani <[email protected]>
…dk/examples/clients/KafkaPublisher.java Co-authored-by: Francesco Guardiani <[email protected]>
slinkydeveloper
approved these changes
Jan 12, 2024
| @@ -1,6 +1,6 @@ | |||
| package dev.restate.sdk.examples.types; | |||
|
|
|||
| public enum Status { | |||
| public enum StatusEnum { | |||
There was a problem hiding this comment.
Why the rename to Enum?
There was a problem hiding this comment.
Because it collided with Status in the proto definitions
slinkydeveloper
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.