Various fixes to make the CDK example pass verification (continued) #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing Java toolchain
pcholakov
requested review from
tillrohrmann and
slinkydeveloper
and removed request for
tillrohrmann
pcholakov
requested review from
tillrohrmann and
slinkydeveloper
and removed request for
slinkydeveloper
This was referenced Jan 15, 2024
tillrohrmann
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Thanks for creating this PR @pcholakov. LGTM. Merging it now :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off https://github.com/restatedev/examples/pull/67/files.
This fixes #65 and #66.