Add TS Tour of Restate #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Thanks for moving the tour of Restate to the examples repository. The changes look good to me. +1 for merging. Please also update https://github.com/restatedev/restate/blob/main/docs/dev/release.md to reflect the latest state.
| @@ -0,0 +1,22 @@ | |||
| /* | |||
| * Copyright (c) 2023 - Restate Software, Inc., Restate GmbH | |||
There was a problem hiding this comment.
Nit: Should this rather be "Copyright (c) 2024"?
There was a problem hiding this comment.
Do we actually need these licenses for an MIT licensed example? It feels so cluttered...
There was a problem hiding this comment.
Not entirely sure. For me, the license headers are pretty much standard and I don't see them anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes restatedev/tour-of-restate#17