Add FindTailAttr for configurable find_tail behavior #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2025
muhamadazmy
force-pushed
the
pr2781
branch
3 times, most recently
from
15a86c4 to
ab3d293
Compare
Summary: FindTailAttr allows find_tail users to adjust durability and accuracy. Currently, two modes are supported: Approximate: A fast check that usually returns immediately with the last known tail. Durable (default): Ensures a reliable tail find. Loglet implementations can choose to always run Durable find_tail.
muhamadazmy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FindTailAttr for configurable find_tail behavior
Summary:
FindTailAttr allows find_tail users to adjust durability and accuracy. Currently, two modes are supported:
Approximate: A fast check that usually returns immediately with the last known tail.
Durable (default): Ensures a reliable tail find.
Loglet implementations can choose to always run Durable find_tail.
Stack created with Sapling. Best reviewed with ReviewStack.