Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6 multipart jetty #1456

Merged
merged 21 commits into from
Apr 4, 2025
Merged

2.6 multipart jetty #1456

merged 21 commits into from
Apr 4, 2025

Conversation

thboileau
Copy link
Contributor

The aim

Add the support of multi-parts representation in the Jetty extension.

Check-list

  • PR size
    • Under 300 lines ✅
    • Can't be split without complicating the process even more
  • Tests
    • Added
    • Not applicable (why?)
  • Doc
    • Added
    • Not applicable
  • Reviewer
    • Asked for a review
    • Added label DO NOT REVIEW

jlouvel and others added 17 commits March 14, 2025 23:25
Added MultiPartFormDataRepresentation to Jetty extension to support generation and parsing.
Added "location" parameter to help set a useful MultiPartConfig in addition to the default Jetty values
Cleanup behavior to generate random boundary just before its usage and only when needed.
Added method to create a Part based on a Representation
Cleanup behavior to generate random boundary just before its usage and only when needed.
Added method to create a Part based on a Representation
Eventually the logic could be reused for related media types
Also added related unit test
jlouvel and others added 4 commits April 1, 2025 22:52
…et/ext/jetty/MultiPartRepresentation.java

Co-authored-by: Thierry Boileau <[email protected]>
…et/ext/jetty/MultiPartRepresentation.java

Co-authored-by: Thierry Boileau <[email protected]>
…et/ext/jetty/MultiPartRepresentation.java

Co-authored-by: Thierry Boileau <[email protected]>
…et/ext/jetty/MultiPartRepresentation.java

Co-authored-by: Thierry Boileau <[email protected]>
@jlouvel
Copy link
Member

jlouvel commented Apr 2, 2025

Thanks @thboileau for the PR! We can apply it I think

@thboileau thboileau merged commit 4401b6c into 2.6 Apr 4, 2025
1 check passed
@thboileau thboileau deleted the 2.6-multipart-jetty branch April 4, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants