-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.6 multipart jetty #1456
Merged
Merged
2.6 multipart jetty #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added MultiPartFormDataRepresentation to Jetty extension to support generation and parsing.
Added "location" parameter to help set a useful MultiPartConfig in addition to the default Jetty values
Cleanup behavior to generate random boundary just before its usage and only when needed. Added method to create a Part based on a Representation
Cleanup behavior to generate random boundary just before its usage and only when needed. Added method to create a Part based on a Representation
Eventually the logic could be reused for related media types
Also added related unit test
thboileau
commented
Apr 1, 2025
....java/org.restlet.ext.jetty/src/main/java/org/restlet/ext/jetty/MultiPartRepresentation.java
Outdated
Show resolved
Hide resolved
thboileau
commented
Apr 1, 2025
....java/org.restlet.ext.jetty/src/main/java/org/restlet/ext/jetty/MultiPartRepresentation.java
Outdated
Show resolved
Hide resolved
thboileau
commented
Apr 1, 2025
....java/org.restlet.ext.jetty/src/main/java/org/restlet/ext/jetty/MultiPartRepresentation.java
Outdated
Show resolved
Hide resolved
thboileau
commented
Apr 1, 2025
....java/org.restlet.ext.jetty/src/main/java/org/restlet/ext/jetty/MultiPartRepresentation.java
Outdated
Show resolved
Hide resolved
…et/ext/jetty/MultiPartRepresentation.java Co-authored-by: Thierry Boileau <[email protected]>
…et/ext/jetty/MultiPartRepresentation.java Co-authored-by: Thierry Boileau <[email protected]>
…et/ext/jetty/MultiPartRepresentation.java Co-authored-by: Thierry Boileau <[email protected]>
…et/ext/jetty/MultiPartRepresentation.java Co-authored-by: Thierry Boileau <[email protected]>
Thanks @thboileau for the PR! We can apply it I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim
Add the support of multi-parts representation in the Jetty extension.
Check-list
DO NOT REVIEW