refactor(any): fix implicit any errors

restorecommerce · May 6, 2024 · f731f1c · f731f1c
1 parent 15c1093
commit f731f1c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/accessControlService.ts b/src/accessControlService.ts
@@ -67,7 +67,7 @@ export class AccessControlService implements AccessControlServiceImplementation
 
     try {
       return this.accessController.isAllowed(acsRequest);
-    } catch (err) { // deny if any error occurs
+    } catch (err: any) { // deny if any error occurs
       this.logger.error('Error evaluating isAllowed request', { code: err.code, message: err.message, stack: err.stack });
       return {
         decision: Response_Decision.DENY,
@@ -88,7 +88,7 @@ export class AccessControlService implements AccessControlServiceImplementation
     let whatisAllowedResponse: ReverseQuery;
     try {
       whatisAllowedResponse = await this.accessController.whatIsAllowed(acsRequest);
-    } catch (err) {
+    } catch (err: any) {
       this.logger.error('Error evaluating whatIsAllowed request', { code: err.code, message: err.message, stack: err.stack });
       return {
         operation_status: {
@@ -118,7 +118,7 @@ export class AccessControlService implements AccessControlServiceImplementation
 
     try {
       return JSON.parse(object.value.toString());
-    } catch (err) {
+    } catch (err: any) {
       this.logger.error('Error unmarshalling object', { code: err.code, message: err.message, stack: err.stack });
       throw err;
     }

diff --git a/src/core/utils.ts b/src/core/utils.ts
@@ -20,6 +20,7 @@ import {
 import { PolicySetWithCombinables, PolicyWithCombinables } from './interfaces.js';
 import { RoleAssociation } from '@restorecommerce/rc-grpc-clients/dist/generated-server/io/restorecommerce/auth.js';
 import { Topic } from '@restorecommerce/kafka-client';
+import { Attribute } from '@restorecommerce/rc-grpc-clients/dist/generated-server/io/restorecommerce/attribute.js';
 
 
 export const formatTarget = (target: any): Target => {
@@ -184,7 +185,7 @@ const getUserServiceClient = async () => {
     // identity-srv client to resolve subject ID by token
     const grpcIDSConfig = cfg.get('client:user');
     const loggerCfg = cfg.get('logger');
-    loggerCfg.esTransformer = (msg) => {
+    loggerCfg.esTransformer = (msg: any) => {
       msg.fields = JSON.stringify(msg.fields);
       return msg;
     };
@@ -230,7 +231,7 @@ export async function checkAccessRequest(ctx: ACSClientContext, resource: Resour
   let result: DecisionResponse | PolicySetRQResponse;
   try {
     result = await accessRequest(subject, resource, action, ctx, { operation, roleScopingEntityURN: cfg?.get('authorization:urns:roleScopingEntityURN') });
-  } catch (err) {
+  } catch (err: any) {
     return {
       decision: Response_Decision.DENY,
       obligations: [],
@@ -344,12 +345,12 @@ export const getAllValues = (obj: any, pushedValues: any): any => {
   }
 };
 
-const nestedAttributesEqual = (redisAttributes, userAttributes) => {
+const nestedAttributesEqual = (redisAttributes: Attribute[], userAttributes: Attribute[]) => {
   if (!userAttributes) {
     return true;
   }
   if (redisAttributes?.length > 0 && userAttributes?.length > 0) {
-    return userAttributes.every((obj) => redisAttributes.some((dbObj => dbObj.value === obj.value)));
+    return userAttributes.every((obj) => redisAttributes.some((dbObj) => dbObj.value === obj.value));
   } else if (redisAttributes?.length != userAttributes?.length) {
     return false;
   }