Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] When defining smart (or straight) with more than 2 entries, the order is evaluated wrong #11

Closed
wants to merge 1 commit into from

Conversation

trueberryless
Copy link
Contributor

@trueberryless trueberryless commented Jan 15, 2025

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

I added one test which demonstrates that the functionality is failing.

TODO

  • remove comments

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Jan 15, 2025

This comment has been minimized.

@trueberryless
Copy link
Contributor Author

trueberryless commented Jan 15, 2025

As you can see here, it currently doesn't find any issues in the third sentence (no 5:*-5:* in actual) because this is how it THINKS that it is correct, alto the config has a different order:

image

@trueberryless
Copy link
Contributor Author

I think that this behaviour is wrong after reading the README.md documentation. It also could be that I entirely misunderstood what the plugins functionality is supposed to be, please let me know if this is the case! Thank you very much in advance!

@trueberryless
Copy link
Contributor Author

Not entirely sure yet (further investigation needed), but I think the problem arises from this line: https://github.com/retextjs/retext-quotes/blob/main/lib%2Findex.js#L119

@trueberryless
Copy link
Contributor Author

Drafting because I don't want this to get merged.
You can close it if you want because #12 resolves the bug...

@trueberryless trueberryless marked this pull request as draft January 15, 2025 12:21
@wooorm wooorm closed this in 8248ab9 Jan 15, 2025
@wooorm wooorm added the 💪 phase/solved Post is done label Jan 15, 2025

This comment has been minimized.

@github-actions github-actions bot removed the 👋 phase/new Post is being triaged automatically label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

2 participants