2.6.1

.github/workflows/test.yml

@@ -23,7 +23,7 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install pytest requests
+          pip install pytest requests unittest
       - name: Test with pytest
         run: |
           pytest

CHANGELOG.md

@@ -304,4 +304,11 @@ v2.5.1 (2024-04-02)
 
 ### Scheduled removals
 - **December 2024.**:
-  - In the `ticloud.DynamicAnalysis.detonate_sample` method the `sample_sha1` parameter will be removed.
+  - In the `ticloud.DynamicAnalysis.detonate_sample` method the `sample_sha1` parameter will be removed.
+
+
+2.6.1 (2024-07-03)
+-------------------
+
+#### Improvements
+- Added more unit tests for all currently available modules.

ReversingLabs/SDK/__init__.py

@@ -5,4 +5,4 @@
 A Python SDK for communicating with ReversingLabs services.
 """
 
-__version__ = "2.6.0"
+__version__ = "2.6.1"

ReversingLabs/SDK/ticloud.py

@@ -3255,15 +3255,19 @@ def __detonate(self, platform, sample_hash=None, url_string=None, is_archive=Fal
         if not isinstance(internet_simulation, bool):
             raise WrongInputError("internet_simulation parameter must be boolean.")
 
-        if internet_simulation:
-            post_json["rl"]["optional_parameters"] = "internet_simulation=true"
-
         if sample_hash:
             hash_type = HASH_LENGTH_MAP.get(len(sample_hash))
             post_json["rl"][hash_type] = sample_hash
 
+            optional_parameters = []
+
             if sample_name:
-                post_json["rl"]["sample_name"] = sample_name
+                optional_parameters.append(f"sample_name={sample_name}")
+
+            if internet_simulation:
+                optional_parameters.append("internet_simulation=true")
+
+            post_json["rl"]["optional_parameters"] = ", ".join(optional_parameters)
 
         elif url_string:
             post_json["rl"]["url"] = url_string

setup.py

@@ -22,7 +22,7 @@
     packages=packages,
     python_requires=">=3.6",
     install_requires=requires,
-    extras_require={"test": ["pytest"]},
+    extras_require={"test": ["pytest", "unittest"]},
     license="MIT",
     zip_safe=False,
     classifiers=[

tests/test_a1000.py

@@ -1,9 +1,13 @@
 import pytest
+from unittest import mock
 from ReversingLabs.SDK import __version__
 from ReversingLabs.SDK.a1000 import CLASSIFICATIONS, AVAILABLE_PLATFORMS, A1000
-from ReversingLabs.SDK.helper import WrongInputError
+from ReversingLabs.SDK.helper import WrongInputError, DEFAULT_USER_AGENT
 
 
+MD5 = "512fca9e83c47fd9c36aa7d50a856396"
+SHA1 = "5377d0ed664246a604363f90a2764aa10fa63ad0"
+SHA256 = "00f8cd09187d311707b52a1c52018e7cfb5f2f78e47bf9200f16281098741422"
 EXPECTED_PLATFORMS = ("windows7", "windows10", "macos_11", "windows11", "linux")
 
 
@@ -44,3 +48,312 @@ def test_a1000_object():
 	authorization = a1000._headers.get("Authorization")
 	assert authorization == f"Token {token}"
 
+
+@pytest.fixture
+def requests_mock():
+	with mock.patch('ReversingLabs.SDK.a1000.requests', autospec=True) as requests_mock:
+		yield requests_mock
+
+
+class TestA1000:
+	host = "https://my.host"
+	token = "token"
+	fields = ("id", "sha1", "sha256", "sha512", "md5", "category", "file_type", "file_subtype",
+	   "identification_name", "identification_version", "file_size", "extracted_file_count",
+	   "local_first_seen", "local_last_seen", "classification_origin", "classification_reason",
+	   "classification_source", "classification", "riskscore", "classification_result", "ticore", "tags",
+	   "summary", "ticloud", "aliases", "networkthreatintelligence", "domainthreatintelligence"
+	   )
+
+	ticore_fields = "sha1, sha256, sha512, md5, imphash, info, application, protection, security, behaviour," \
+					" certificate, document, mobile, media, web, email, strings, interesting_strings," \
+					" classification, indicators, tags, attack, story"
+
+	@classmethod
+	def setup_class(cls):
+		cls.a1000 = A1000(cls.host, token=cls.token)
+
+	def test_sample_from_url(self, requests_mock):
+		self.a1000.upload_sample_from_url(file_url="https://some.url")
+
+		expected_url = f"{self.host}/api/uploads/"
+
+		requests_mock.post.assert_called_with(
+			url=expected_url,
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None,
+			json=None,
+			data={"url": "https://some.url", "analysis": "cloud"},
+			files=None
+		)
+
+	def test_wrong_id(self, requests_mock):
+		with pytest.raises(WrongInputError, match=r"task_id parameter must be a string."):
+			self.a1000.get_submitted_url_report(task_id=123, retry=False)
+
+		assert not requests_mock.get.called
+
+	def test_classification(self, requests_mock):
+		self.a1000.get_classification_v3(sample_hash=SHA1, local_only=True)
+
+		expected_url = f"{self.host}/api/samples/v3/{SHA1}/classification/?localonly=1&av_scanners=0"
+
+		requests_mock.get.assert_called_with(
+			url=expected_url,
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None
+		)
+
+	def test_reanalyze(self, requests_mock):
+		self.a1000.reanalyze_samples_v2(
+			hash_input=SHA1,
+			titanium_cloud=True
+		)
+
+		data = {
+			"hash_value": [SHA1],
+			"analysis": "cloud",
+			"rl_cloud_sandbox_platform": None
+		}
+
+		requests_mock.post.assert_called_with(
+			url=f"{self.host}/api/samples/v2/analyze_bulk/",
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None,
+			json=None,
+			data=data,
+			files=None
+		)
+
+	def test_extracted_files(self, requests_mock):
+		self.a1000.list_extracted_files_v2(SHA1)
+
+		requests_mock.get.assert_called_with(
+			url=f"{self.host}/api/samples/v2/{SHA1}/extracted-files/",
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None
+		)
+
+	def test_download_extracted(self, requests_mock):
+		self.a1000.download_extracted_files(SHA1)
+
+		requests_mock.get.assert_called_with(
+			url=f"{self.host}/api/samples/{SHA1}/unpacked/",
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None
+		)
+
+	def test_delete_file(self, requests_mock):
+		self.a1000.delete_samples([SHA1, SHA1])
+
+		data = {"hash_values": [SHA1, SHA1]}
+
+		requests_mock.post.assert_called_with(
+			url=f"{self.host}/api/samples/v2/delete_bulk/",
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None,
+			json=None,
+			data=data,
+			files=None
+		)
+
+	def test_pdf_report(self, requests_mock):
+		self.a1000.create_pdf_report(SHA1)
+
+		requests_mock.get.assert_called_with(
+			url=f"{self.host}/api/pdf/{SHA1}/create",
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None
+		)
+
+	def test_ticore_report(self, requests_mock):
+		self.a1000.get_titanium_core_report_v2(SHA1)
+
+		expected_url = f"{self.host}/api/v2/samples/{SHA1}/ticore/?fields={self.ticore_fields}"
+
+		requests_mock.get.assert_called_with(
+			url=expected_url,
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None
+		)
+
+	def test_dynamic_report(self, requests_mock):
+		self.a1000.create_dynamic_analysis_report(SHA1, "pdf")
+
+		expected_url = f"{self.host}/api/rl_dynamic_analysis/export/summary/{SHA1}/pdf/create/"
+
+		requests_mock.get.assert_called_with(
+			url=expected_url,
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None
+		)
+
+	def test_wrong_dynamic_params(self, requests_mock):
+		with pytest.raises(WrongInputError, match=r"report_format parameter must be either 'html' or 'pdf'."):
+			self.a1000.download_dynamic_analysis_report(SHA1, "xml")
+
+		assert not requests_mock.get.called
+
+	def test_set_classification(self, requests_mock):
+		self.a1000.set_classification(SHA1, classification="malicious", system="local")
+
+		data = {
+			"classification": "malicious",
+			"analysis": "cloud"
+		}
+
+		expected_url = f"{self.host}/api/samples/{SHA1}/setclassification/local/"
+
+		requests_mock.post.assert_called_with(
+			url=expected_url,
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None,
+			json=None,
+			data=data,
+			files=None
+		)
+
+	def test_user_tags(self, requests_mock):
+		self.a1000.post_user_tags(SHA1, ["tag1", "tag2"])
+
+		post_json = {"tags": ["tag1", "tag2"]}
+
+		expected_url = f"{self.host}/api/tag/{SHA1}/"
+
+		requests_mock.post.assert_called_with(
+			url=expected_url,
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None,
+			json=post_json,
+			data=None,
+			files=None
+		)
+
+	def test_yara(self, requests_mock):
+		self.a1000.get_yara_rulesets_on_the_appliance_v2(source="all")
+
+		expected_url = f"{self.host}/api/yara/v2/rulesets/?source=all"
+
+		requests_mock.get.assert_called_with(
+			url=expected_url,
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None
+		)
+
+	def test_enable_yara(self, requests_mock):
+		self.a1000.enable_or_disable_yara_ruleset(
+			enabled=True,
+			name="the_ruleset",
+			publish=True
+		)
+
+		data = {
+			"name": "the_ruleset",
+			"publish": True,
+			"analysis": "cloud"
+		}
+
+		expected_url = f"{self.host}/api/yara/ruleset/enable/"
+
+		requests_mock.post.assert_called_with(
+			url=expected_url,
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None,
+			json=None,
+			data=data,
+			files=None
+		)
+
+	def test_start_yara_retro(self, requests_mock):
+		self.a1000.start_or_stop_yara_local_retro_scan("START")
+
+		requests_mock.post.assert_called_with(
+			url=f"{self.host}/api/uploads/local-retro-hunt/",
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None,
+			json=None,
+			data={"operation": "START"},
+			files=None
+		)
+
+	def test_wrong_operation(self, requests_mock):
+		with pytest.raises(WrongInputError, match=r"operation parameter must be either 'START' or 'STOP'"):
+			self.a1000.start_or_stop_yara_local_retro_scan("BEGIN")
+
+		assert not requests_mock.post.called
+
+	def test_advanced_search(self, requests_mock):
+		self.a1000.advanced_search_v3(query_string="av-count:5 available:TRUE", sorting_criteria="sha1", sorting_order="desc", page_number=2, records_per_page=5)
+
+		post_json = {"query": "av-count:5 available:TRUE", "ticloud": False, "page": 2,
+					 "records_per_page": 5, "sort": "sha1 desc"}
+
+		requests_mock.post.assert_called_with(
+			url=f"{self.host}/api/samples/v3/search/",
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None,
+			json=post_json,
+			data=None,
+			files=None
+		)
+
+	def test_list_containers(self, requests_mock):
+		self.a1000.list_containers_for_hashes([SHA1, SHA1])
+
+		data = {"hash_values": [SHA1, SHA1]}
+
+		requests_mock.post.assert_called_with(
+			url=f"{self.host}/api/samples/containers/",
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None,
+			json=None,
+			data=data,
+			files=None
+		)
+
+	def test_network_report(self, requests_mock):
+		domain = "some.test.domain"
+
+		self.a1000.network_domain_report(domain)
+
+		expected_url = f"{self.host}/api/network-threat-intel/domain/{domain}/"
+
+		requests_mock.get.assert_called_with(
+			url=expected_url,
+			verify=True,
+			proxies=None,
+			headers={"User-Agent": DEFAULT_USER_AGENT, "Authorization": f"Token {self.token}"},
+			params=None
+		)