-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(detect-scan): support input for .secrets.baseline
path
#51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach will create and store the artifact .secrets.baseline
in the working directory. This is unexpected behavior for an optional feature.
I suggest moving the .secrets.baseline
file to a temporary container directory /tmp/
. And if stdout data needs access, then changing the path to the file as addition option.
Thanks for your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that these changes will not change the usual behavior. Ping me if I can merge it.
@levonet Thanks ! You can merge it |
🚀 [bumpr] Bumped! New version:v0.15.0 Changes:v0.14.0...v0.15.0 |
Hi, @SoaAlex! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
Issue
When
.secrets.baseline
is provided, the file is only updated and not written to stdout.Therefore, the pipe to
baseline2rdf
doesn't work as there is no JSON to parse.Proposed solution
.secrets.baseline
)..secrets.baseline
.secrets.baseline
and pipe it tobaseline2rdf
andreviewdog
commands.This was not tested, and it might contains errors, please don't hesitate to fix it or suggest any modification :)