Adding tests for before validation, no bang

lib/action_logic/action_validation.rb

@@ -9,6 +9,10 @@ def validates_before!(args)
         @validates_before = args.merge(raise_action_logic_exception: true)
       end
 
+      def validates_before(args)
+        @validates_before = args.merge(raise_action_logic_exception: false)
+      end
+
       def validates_after(args)
         @validates_after = args.merge(raise_action_logic_exception: true)
       end

spec/action_logic/active_use_case_spec.rb

@@ -153,7 +153,7 @@ module ActionLogic
     end
 
     describe "before validations" do
-      describe "required attributes and type validation" do
+      describe "required attributes and type validation with bang" do
         it "does not raise error if context has required keys and values are of the correct type" do
           expect { ValidateBeforeTestUseCaseWithBang.execute(Constants::VALID_ATTRIBUTES) }.to_not raise_error
         end
@@ -169,6 +169,23 @@ module ActionLogic
         end
       end
 
+      describe "required attributes and type validation" do
+        it "does not raise error if context has required keys and values are of the correct type" do
+          expect { ValidateBeforeTestUseCase.execute(Constants::VALID_ATTRIBUTES) }.to_not raise_error
+        end
+
+        it "doesn't raise error if context is missing required keys" do
+          expect { ValidateBeforeTestUseCase.execute() }.to_not\
+            raise_error(ActionLogic::MissingAttributeError)
+        end
+
+        it "raises error if context has required key but is not of correct type" do
+          expect { ValidateBeforeTestUseCase.execute(Constants::INVALID_ATTRIBUTES) }.to_not\
+            raise_error(ActionLogic::AttributeTypeError)
+        end
+      end
+
+
       describe "custom types" do
         it "allows validation against custom defined types" do
           expect { ValidateBeforeCustomTypeTestUseCaseWithBang.execute(Constants::CUSTOM_TYPE_ATTRIBUTES1) }.to_not raise_error

spec/fixtures/use_cases.rb

@@ -189,6 +189,76 @@ def tasks
   end
 end
 
+class ValidateBeforeTestUseCase
+  include ActionLogic::ActionUseCase
+
+  validates_before Constants::ALL_VALIDATIONS
+
+  def call
+  end
+
+  def tasks
+    [UseCaseTestTask1,
+     UseCaseTestTask2]
+  end
+end
+
+class ValidateBeforePresenceTestUseCase
+  include ActionLogic::ActionUseCase
+
+  validates_before Constants::PRESENCE_VALIDATION
+
+  def call
+  end
+
+  def tasks
+    [UseCaseTestTask1,
+     UseCaseTestTask2]
+  end
+end
+
+class ValidateBeforeCustomPresenceTestUseCase
+  include ActionLogic::ActionUseCase
+
+  validates_before Constants::CUSTOM_PRESENCE_VALIDATION
+
+  def call
+  end
+
+  def tasks
+    [UseCaseTestTask1,
+     UseCaseTestTask2]
+  end
+end
+
+class ValidateBeforeCustomTypeTestUseCase
+  include ActionLogic::ActionUseCase
+
+  validates_before Constants::CUSTOM_TYPE_VALIDATION1
+
+  def call
+  end
+
+  def tasks
+    [UseCaseTestTask1,
+     UseCaseTestTask2]
+  end
+end
+
+class ValidateBeforeUnrecognizablePresenceTestUseCase
+  include ActionLogic::ActionUseCase
+
+  validates_before :integer_test => { :presence => :true }
+
+  def call
+  end
+
+  def tasks
+    [UseCaseTestTask1,
+     UseCaseTestTask2]
+  end
+end
+
 class ValidateBeforeTestUseCaseWithBang
   include ActionLogic::ActionUseCase
 
@@ -248,7 +318,7 @@ def tasks
 class ValidateBeforeUnrecognizablePresenceTestUseCaseWithBang
   include ActionLogic::ActionUseCase
 
-  validates_before! :integer_test => { :presence => :true }
+  validates_before :integer_test => { :presence => :true }
 
   def call
   end