Adds clean component ignore list #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added specs
| @@ -197,5 +199,10 @@ def find_command(cmd, paths = []) | |||
| def main_files_for_component(name) | |||
| Array(dsl.main_files[name]) | |||
| end | |||
|
|
|||
| def clean_should_skip_component?(name) | |||
| BowerRails.exclude_from_clean.respond_to?(:include?) && | |||
There was a problem hiding this comment.
I think we can add default option as an empty array here and skip this check
There was a problem hiding this comment.
My thinking here was that potentially someone could set config.exclude_from_clean = nil and it wouldn't be handled very well. This way the default action doesn't skip, malformed config doesn't skip and it also allows for config with basic string. i.e. config.exclude_from_clean = 'moment'
There was a problem hiding this comment.
Well, this makes sence
SergeyKishenin
added a commit
that referenced
this pull request
Aug 20, 2015
Adds clean component ignore list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for a list of bower components to be exempt from the clean.
Another option might be to implement something like as suggested in #160 but for the one package where I needed something outside of the main, this seemed suitable.