Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workflows for webui integration tests #5382

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

VladimirSlavik
Copy link
Contributor

These are not used any more, they are in the webui repo and merged with the regular tests.

@github-actions github-actions bot added infrastructure Changes affecting mostly infrastructure documentation f40 labels Dec 15, 2023
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we want to maintain the status badges for the moved workflows to the new repository, just with adjusted links. See cockpit-lib-update.

As far the webui e2e tests workflow deletion, it's a bit unknown ground, as in the new repository there is not any script that builds ISOs, which these tests used to use.

But I agree, these dont belong here anymore.

@VladimirSlavik
Copy link
Contributor Author

Right, I'll re-add the badge under a new heading.

@KKoukiou KKoukiou added f41 and removed f40 labels Feb 29, 2024
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These do not run some months now, and when/if they are going to be reintroduced let's do that in the anaconda-webui repository.

@KKoukiou KKoukiou force-pushed the master-no-webui-tests branch from 1939783 to 74a366a Compare March 26, 2024 10:14
@KKoukiou KKoukiou requested a review from jkonecny12 March 26, 2024 10:18
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@KKoukiou
Copy link
Contributor

/kickstart-test --waive infra only

@KKoukiou KKoukiou merged commit bf66eb9 into rhinstaller:master Mar 27, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation f41 infrastructure Changes affecting mostly infrastructure
Development

Successfully merging this pull request may close these issues.

3 participants