Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: packit: get version from specfile #5383

Closed
wants to merge 1 commit into from
Closed

infra: packit: get version from specfile #5383

wants to merge 1 commit into from

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Dec 15, 2023 •
edited
Loading

No description provided.

@github-actions github-actions bot added the f40 label Dec 15, 2023
@KKoukiou
infra: packit: get version from specfile
366484f 
Packit gets it from the latest pushed tag, ignoring branches,
which is problematic for us who push tags for RHEL with different
versioning.
@KKoukiou KKoukiou force-pushed the fix-packit-copr-master branch from 2456d85 to 366484f Compare December 15, 2023 20:17
@KKoukiou KKoukiou changed the title infra: remove target for copr builds from commits in master infra: packit: get version from specfile Dec 15, 2023
VladimirSlavik
VladimirSlavik approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkonecny12
Copy link
Member

Looks great to me. Thanks for the improvement.

M4rtinK
M4rtinK approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, thanks! :)

KKoukiou
KKoukiou commented Jan 3, 2024
View reviewed changes
Copy link
Contributor Author

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work as the anaconda.spec is generated on build time.

KKoukiou
KKoukiou commented Jan 3, 2024
View reviewed changes
Copy link
Contributor Author

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was meant to be a workaround for packit/packit#2184 but it's not possible as the anaconda.spec is generated at build time from the template file.

@KKoukiou KKoukiou closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

@jkonecny12 jkonecny12 jkonecny12 approved these changes

@vojtechtrefny vojtechtrefny vojtechtrefny approved these changes

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees
No one assigned
Labels
f40
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KKoukiou @jkonecny12 @M4rtinK @vojtechtrefny @VladimirSlavik