Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network spokes connectivity check #5394

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix network spokes connectivity check #5394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyanaconda/ui/gui/spokes/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,7 +1540,7 @@ def completed(self):
# TODO: check also if source requires updates when implemented
# If we can't configure network, don't require it
return (not conf.system.can_configure_network
or self._network_module.GetActivatedInterfaces())
or self._network_module.Connected)

@property
def mandatory(self):
Expand Down Expand Up @@ -1691,7 +1691,7 @@ def apply(self):
@property
def completed(self):
return (not conf.system.can_configure_network
or self._network_module.GetActivatedInterfaces()
or self._network_module.Connected
or not (self.payload.source_type != conf.payload.default_source
and self.payload.needs_network))

Expand Down
2 changes: 1 addition & 1 deletion pyanaconda/ui/tui/spokes/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ def completed(self):
""" Check whether this spoke is complete or not."""
# If we can't configure network, don't require it
return (not conf.system.can_configure_network
or self._network_module.GetActivatedInterfaces())
or self._network_module.Connected)

@property
def mandatory(self):
Expand Down
Loading