Conversation
The script is mainly based on comparing the /root/lorax-packages.log files embedded in boot.iso images and provides information about package differences between two boot.iso images. As long as the unsquashfs tool is available it is possible to compare images without sudo. If the tool is not available an alternative method requiring sudo is used. The tool can also output machine readable data in JSON format. Assisted-by: Cursor
Summary of ChangesHello @M4rtinK, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Python utility designed to streamline the comparison of Fedora boot ISO images. Its primary function is to identify discrepancies in the installed software packages by analyzing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new Python script, compare_iso, for comparing package contents of two Fedora ISO images. The script is well-structured, using a class to encapsulate the comparison logic and a context manager for resource cleanup. It robustly handles dependencies on external tools by providing fallbacks. My review focuses on improving robustness, correctness, and adherence to best practices. I've identified several high-severity bugs related to error handling and package name parsing, and medium-severity issues concerning unused imports and logging practices. The provided suggestions aim to fix these issues and make the script more reliable and maintainable.
KKoukiou
left a comment
There was a problem hiding this comment.
I like the idea of having such a script, but it would need at least one test, for commiting this to the repo.
Sure, lets do that - I think I would skip comparing actual images as that would require downloading 1+GB of stuff for every invocation,, but I can do some less resource intesive testing for now, like checking it correctly handles edge cases (no imag provided, 2 empty files, etc.). :) |
|
This PR is stale because it has been open 60 days with no activity. |
The script is mainly based on comparing the /root/lorax-packages.log files embedded in boot.iso images and provides information about package differences between two boot.iso images.
As long as the unsquashfs tool is available it is possible to compare images without sudo. If the tool is not available an alternative method requiring sudo is used.
The tool can also output machine readable data in JSON format.
Assisted-by: Cursor