modules: runtime: Expose AutomatedInstall and InteractiveMode on Runtime UserInterface#6980
modules: runtime: Expose AutomatedInstall and InteractiveMode on Runtime UserInterface#6980KKoukiou wants to merge 3 commits intorhinstaller:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Anaconda installer's runtime environment by exposing critical installation mode flags, Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request exposes AutomatedInstall and InteractiveMode flags on the UserInterface DBus service, allowing UIs to be aware of the installation mode. The changes look good, but I have a few suggestions to improve the implementation. My main feedback is regarding the new DBus methods, which should notify clients when the properties change, to allow UIs to react accordingly. I've also suggested a minor code organization improvement in anaconda.py.
| def SetAutomatedInstall(self, value: Bool): | ||
| """Set AutomatedInstall.""" | ||
| self.implementation.set_automated_install(value) |
There was a problem hiding this comment.
This method updates the AutomatedInstall property, but it doesn't notify listening DBus clients about the change. To enable notifications, you should:
- In
UIModule(ui.py), add aautomated_install_changed = Signal()in__init__and callself.automated_install_changed.emit()inset_automated_install. - In this file, add
self.watch_property("AutomatedInstall", self.implementation.automated_install_changed)toconnect_signals.
For better API consistency with other settable properties like DisplayMode, consider refactoring this to a property setter (@AutomatedInstall.setter). This would also require decorating it with @emits_properties_changed and updating the call site in anaconda.py to use property assignment (e.g., ui_proxy.AutomatedInstall = ...).
| def SetInteractiveMode(self, value: Bool): | ||
| """Set InteractiveMode.""" | ||
| self.implementation.set_interactive_mode(value) |
There was a problem hiding this comment.
Similar to SetAutomatedInstall, this method updates the InteractiveMode property but doesn't notify DBus clients. To enable notifications, you should:
- In
UIModule(ui.py), add aninteractive_mode_changed = Signal()in__init__and callself.interactive_mode_changed.emit()inset_interactive_mode. - In this file, add
self.watch_property("InteractiveMode", self.implementation.interactive_mode_changed)toconnect_signals.
For better API consistency, consider refactoring this to a property setter (@InteractiveMode.setter) and updating its call site.
| # Expose to UIs via Runtime UserInterface: AutomatedInstall and | ||
| # InteractiveMode (matches anaconda.interactive_mode). Fully automated | ||
| # when AutomatedInstall True and InteractiveMode False. | ||
| from pyanaconda.modules.common.constants.objects import USER_INTERFACE |
There was a problem hiding this comment.
This local import can be moved to group it with other similar imports for better code organization. Specifically, you can add USER_INTERFACE to the import statement on line 357 (which is outside this diff) and remove this line.
…ime UserInterface
Wait on the installation summary for user confirmation before starting install when using a kickstart. Expose PauseAtSummary on the Runtime UserInterface DBus object; GUI hub auto-continue and TUI summary hub honor the flag. Document the boot option and wire argparse/--help.
Do not allow yet partial KS installations.
KKoukiou
force-pushed
the
webui-automated-installations
branch
from
f698d49 to
6b8d327
Compare
|
/kickstart-tests --testtype smoke |
1 participant
No description provided.