conf: Add [Runtime] for install session flags (runtime file only)#7001
Open
adamkankovsky wants to merge 1 commit intorhinstaller:mainfrom
Open
conf: Add [Runtime] for install session flags (runtime file only)#7001adamkankovsky wants to merge 1 commit intorhinstaller:mainfrom
adamkankovsky wants to merge 1 commit intorhinstaller:mainfrom
Conversation
adamkankovsky
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
adamkankovsky
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new [Runtime] configuration section to manage and publish installation session flags, specifically automated_install and interactive_mode, to the runtime anaconda.conf file. Feedback focuses on improving the robustness of the configuration initialization by ensuring individual options are set if missing, and enhancing the set_runtime_install_session method to respect environment variables for better testability while validating the configuration before it is written to disk.
adamkankovsky
force-pushed
the
runtime-conf-section-automated-ks
branch
from
80c2378 to
9412d7f
Compare
adamkankovsky
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
adamkankovsky
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
Expose automated_install and interactive_mode via conf.runtime. Values are written to /run/anaconda/anaconda.conf.
adamkankovsky
force-pushed
the
runtime-conf-section-automated-ks
branch
from
9412d7f to
2c19c59
Compare
adamkankovsky
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
adamkankovsky
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested in interactive and non-interactive mode and it works.