Enable hermetic builds for Thanos #779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmellado
force-pushed
the
add_hermetic_thanos
branch
from
e573a30 to
a436043
Compare
danielmellado
force-pushed
the
add_hermetic_thanos
branch
from
a436043 to
02d3a8b
Compare
danielmellado
force-pushed
the
add_hermetic_thanos
branch
from
02d3a8b to
4cc45ea
Compare
danielmellado
changed the title
jan--f
approved these changes
Mar 10, 2025
| @@ -197,8 +197,6 @@ spec: | |||
| value: $(params.output-image).prefetch | |||
| - name: ociArtifactExpiresAfter | |||
| value: $(params.image-expires-after) | |||
| - name: dev-package-managers | |||
| value: $(params.prefetch-dev-package-managers-enabled) | |||
There was a problem hiding this comment.
Hmm the task params shouldn't need changing. what am I missing? Afaict this is just how the pipeline tasks works.
Otoh this doesn't seem to hurt for now so feel free to go ahead and merge.
There was a problem hiding this comment.
Hi, as we'll no longer use the rpm dev package manager we won't be needing for now to enable this at all so I thought about reducing the noise and just keep it off ;)
This needed a rebase in any case so I'll merge once CI is done, thanks!
danielmellado
force-pushed
the
add_hermetic_thanos
branch
from
4cc45ea to
aa1c8e1
Compare
danielmellado
changed the title
|
/retest |
1 similar comment
|
/retest |
danielmellado
force-pushed
the
add_hermetic_thanos
branch
2 times, most recently
from
9579b3f to
299a852
Compare
This commit enables hermetic builds for Thanos. It also modifies its Dockerfile to skip using promu and removes the rpm fetcher configuration given that COO is in the public cluster and can't access internal RH network. This is dependent on openshift/thanos#159. Otherwise this would fail to find the golang toolchain. Signed-off-by: Daniel Mellado <[email protected]>
danielmellado
force-pushed
the
add_hermetic_thanos
branch
from
299a852 to
1492d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables hermetic builds for Thanos. It also modifies its
Dockerfile to skip using promu and removes the rpm fetcher configuration
given that COO is in the public cluster and can't access internal RH
network.
This is dependent on openshift/thanos#159.
Otherwise this would fail to find the golang toolchain.
Signed-off-by: Daniel Mellado [email protected]