-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD-28131: Deploying COO in place of OBO on SC clusters #667
base: main
Are you sure you want to change the base?
Conversation
@Nikokolas3270: This pull request references OSD-28131 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hi @Nikokolas3270. Thanks for your PR. I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Nikokolas3270 @apahim is still pr still required? |
@Nikokolas3270: This pull request references OSD-28131 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jan--f , yes it is still required... but most of the code moved there: |
/lgtm |
1e2e4f2
to
32eec6b
Compare
/lgtm |
/retest |
Checkout the commit lint results. We follow conventional commits. A prefix of |
32eec6b
to
f2a452d
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, Nikokolas3270 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR removes OBO subscription from Hypershift service clusters (SCs)
The following MR install COO on those clusters:
https://gitlab.cee.redhat.com/service/osd-fleet-manager/-/merge_requests/1043
This MR must be merged after above PR