Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD-28131: Deploying COO in place of OBO on SC clusters #667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nikokolas3270
Copy link

@Nikokolas3270 Nikokolas3270 commented Feb 4, 2025

This PR removes OBO subscription from Hypershift service clusters (SCs)

The following MR install COO on those clusters:
https://gitlab.cee.redhat.com/service/osd-fleet-manager/-/merge_requests/1043

This MR must be merged after above PR

@Nikokolas3270 Nikokolas3270 requested a review from a team as a code owner February 4, 2025 14:43
@Nikokolas3270 Nikokolas3270 requested review from JoaoBraveCoding and PeterYurkovich and removed request for a team February 4, 2025 14:43
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 4, 2025

@Nikokolas3270: This pull request references OSD-28131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Do not merge yet

COO is deployed through the "Red Hat" catalog.
However it is not 100% sure if COO will be deployed through this catalog.
Below article seems to imply that the operator will be deployed through one of the default catalog... and "Red Hat" is one of them:
https://access.redhat.com/articles/7103797

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Feb 4, 2025

Hi @Nikokolas3270. Thanks for your PR.

I'm waiting for a rhobs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jan--f
Copy link
Collaborator

jan--f commented Feb 20, 2025

@Nikokolas3270 @apahim is still pr still required?

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 5, 2025

@Nikokolas3270: This pull request references OSD-28131 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This PR removes OBO subscription from Hypershift service clusters (SCs)

The following MR install COO on those clusters:
https://gitlab.cee.redhat.com/service/osd-fleet-manager/-/merge_requests/1043

This MR must be merged after above PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Nikokolas3270 Nikokolas3270 marked this pull request as ready for review March 5, 2025 11:31
@openshift-ci openshift-ci bot requested a review from danielmellado March 5, 2025 11:31
@Nikokolas3270
Copy link
Author

@Nikokolas3270 @apahim is still pr still required?

@jan--f , yes it is still required... but most of the code moved there:
https://gitlab.cee.redhat.com/service/osd-fleet-manager/-/merge_requests/1043

@jan--f
Copy link
Collaborator

jan--f commented Mar 11, 2025

/lgtm
/approve

@jan--f
Copy link
Collaborator

jan--f commented Mar 11, 2025

@jan--f
Copy link
Collaborator

jan--f commented Mar 12, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 12, 2025
@jan--f
Copy link
Collaborator

jan--f commented Mar 12, 2025

/retest

@jan--f
Copy link
Collaborator

jan--f commented Mar 12, 2025

Checkout the commit lint results. We follow conventional commits. A prefix of chore: should fix it.

@jan--f
Copy link
Collaborator

jan--f commented Mar 19, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Mar 19, 2025
Copy link

openshift-ci bot commented Mar 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, Nikokolas3270

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants