-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed: Fix compatibility_matrix so OCP v4.15+ deploys logging image containing PF5 #710
Conversation
Signed-off-by: Alberto Falossi <[email protected]>
Signed-off-by: Jan Fajerski <[email protected]>
@zhuje: This pull request references COO-749 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@zhuje: This pull request references COO-749 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@zhuje: This pull request references COO-749 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@zhuje: This pull request references COO-749 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…v4.15.0) Signed-off-by: Jenny Zhu <[email protected]>
28bf934
to
bfe9529
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhuje The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Jenny Zhu <[email protected]>
closed --- redirected here #712 (I messed up the rebase. I rebased with |
@zhuje: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Closed. See new PR #712.
Description
This PR tries to fix
compareClusterVersion
so OCP cluster version >= 4.15.0-0 returnsImageKey: "ui-logging",
.ImageKey
ui-logging
contains Patternfly5 which is compatible with OCP cluster version is v4.15+.During testing it was discovered OCP cluster version v4.15.x is returning ImageKey
ui-logging-p4
which contains Patternfly4 which is no longer compatible with OCP v4.15+.This PR tries to fix the compatibility matrix to return ImageKey
ui-logging
when OCP cluster version v4.15+.JIRA
[COO1.1] - OCP4.15 - ui-logging-pf4 (v6.0) is deployed instead of ui-logging (v6.1)
Context
Before
canonicalMaxClusterVersion := semver.Canonical(entry.MaxClusterVersion)
(e.g canonicalMaxClusterVersion = v4.15.0)
After
canonicalMaxClusterVersion := fmt.Sprintf("%s-0", semver.Canonical(entry.MaxClusterVersion))
(e.g canonicalMaxClusterVersion = v4.15.0-0)