song code rewrite and stuff #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still making it fallback to the chart data, not sure if I want PlayState to be able to work without a reference to a Song object or not
it's only used because of psych week shit should maybe add difficulties to the metadata so menus can use them idk i want freeplay songs to be able to behave independently from their weeks/levels
hmmm might not go with this
song variations shouldn't have their metadata embedded into the chart file from now on
that fucking legacy fnf that i hate
the loadSong stuff except it doesn't set any PlayState values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
making a pr for this just to keep a lil summary of this commit nuke lol
Add the following functions to
SonginstancesgetSongFile(fileName)getMetadata(chartId)getSwagSong(chartId)Removed
Song.difficultiesbecause this was mostly unused and only really existed because of psych weeksdifficultyIdxargument inloadSongbecause it was kinda redundant, again only existed because of psychAdded a
songNamefield toSongMetadataused to set the displayed name of the songBecause of that
Song.songNamewas replaced withSong.songId, this will be used to save the song's high-scoresAdded a
PlayState.songproperty to access the current song'sSongMetadataandsongIdas well as audio tracks for the songSwagSong.songwill now be ignored for saving song high-scores and setting the song display name so long asPlayState.songisn't null