WEB3-79: Refactor of Governance Example for RISC Zero zkVM 1.0 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… section for data
github-actions
bot
changed the title
|
Lots of CI issues, I will take a look at a stab at fixing these later today/early this coming week |
nategraf
reviewed
Sep 6, 2024
examples/governance/apps/README.md
Outdated
|
|
||
| In typical applications, an off-chain app is needed to do two main actions: | ||
|
|
||
| * Produce a proof (see [proving options]). |
There was a problem hiding this comment.
This link reference is broken. It'd recommend using a linter that can check for this. I use markdownlint in my editor. I'm interested in integrating markdown linting into CI, but haven't found the right approach (markdownlint itself is too noisy to enforce), so if you have any suggestions!
Suggested change
| * Produce a proof (see [proving options]). | |
| * Produce a proof (see [proving options][proving-options]). |
There was a problem hiding this comment.
Ah now I understand, thanks for that. I know Nuke had some discussions with Frank about lychee and that's now used in the main risc0 monorepo CI iirc, perhaps for consistency, it would make sense to use it in this repo as well
nategraf
reviewed
Sep 11, 2024
nategraf
approved these changes
Sep 13, 2024
sashaaldrick
added a commit
that referenced
this pull request
Sep 17, 2024
This is a refactor of the original governance example located in release-0.20 [here](https://github.com/risc0/risc0/tree/release-0.20/bonsai/examples/governance). This has been rewritten to match the foundry template layout, amongst many other features. At a high level, this PR: - upgrades governance example guest to zkVM 1.0 - deprecates Relay workflow and contracts - updates publisher to handle deprecated relay workflows - simplifies test logic for readability - creates gas benchmarks from these tests For a high level walkthrough, please see [README.md](https://github.com/risc0/risc0-ethereum/blob/a5ccf7872c3d8dfe86d42816b2388da4e27af4c3/examples/governance/README.md), and to run tests locally with benchmarking, see [instructions.md](https://github.com/risc0/risc0-ethereum/blob/a5ccf7872c3d8dfe86d42816b2388da4e27af4c3/examples/governance/instructions.md). --------- Co-authored-by: Angelo Capossele <[email protected]> Co-authored-by: Victor Graf <[email protected]>
sashaaldrick
added a commit
that referenced
this pull request
Sep 17, 2024
This is a refactor of the original governance example located in release-0.20 [here](https://github.com/risc0/risc0/tree/release-0.20/bonsai/examples/governance). This has been rewritten to match the foundry template layout, amongst many other features. At a high level, this PR: - upgrades governance example guest to zkVM 1.0 - deprecates Relay workflow and contracts - updates publisher to handle deprecated relay workflows - simplifies test logic for readability - creates gas benchmarks from these tests For a high level walkthrough, please see [README.md](https://github.com/risc0/risc0-ethereum/blob/a5ccf7872c3d8dfe86d42816b2388da4e27af4c3/examples/governance/README.md), and to run tests locally with benchmarking, see [instructions.md](https://github.com/risc0/risc0-ethereum/blob/a5ccf7872c3d8dfe86d42816b2388da4e27af4c3/examples/governance/instructions.md). --------- Co-authored-by: Angelo Capossele <[email protected]> Co-authored-by: Victor Graf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor of the original governance example located in release-0.20 here. This has been rewritten to match the foundry template layout, amongst many other features.
At a high level, this PR:
For a high level walkthrough, please see README.md, and to run tests locally with benchmarking, see instructions.md.