WEB3-99: feat: add EvmEnvBuilder #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Wollac
commented
Sep 2, 2024
| @@ -45,8 +45,11 @@ pub(crate) type HostEvmEnv<D, H> = EvmEnv<TraceDb<D>, H>; | |||
| impl EthEvmEnv<TraceDb<AlloyDb<Http<Client>, Ethereum, RootProvider<Http<Client>>>>> { | |||
| /// Creates a new provable [EvmEnv] for Ethereum from an HTTP RPC endpoint. | |||
| pub async fn from_rpc(url: Url, number: BlockNumberOrTag) -> Result<Self> { | |||
There was a problem hiding this comment.
Should this now redundant function be removed, or at least marked as #[deprecated]?
There was a problem hiding this comment.
Maybe we mark it as deprecated for one release to avoid needless pain to our devs.
|
supersedes #204 |
capossele
approved these changes
Sep 2, 2024
nategraf
approved these changes
Sep 3, 2024
Co-authored-by: Victor Graf <[email protected]>
intoverflow
approved these changes
Sep 4, 2024
nategraf
added a commit
that referenced
this pull request
Sep 10, 2024
Add the `EvmEnvBuilder` to simplify the creation of an `EvmEnv` on the host. See #204 for more context. --------- Co-authored-by: Victor Graf <[email protected]>
nategraf
added a commit
that referenced
this pull request
Sep 10, 2024
Add the `EvmEnvBuilder` to simplify the creation of an `EvmEnv` on the host. See #204 for more context. --------- Co-authored-by: Victor Graf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
EvmEnvBuilderto simplify the creation of anEvmEnvon the host.See #204 for more context.