Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB3-105: chore: corruption tests for Steel #241

Merged
merged 7 commits into from
Sep 12, 2024
Merged

Conversation

Wollac
Copy link
Contributor

@Wollac Wollac commented Sep 12, 2024

This PR adds tests to ensure that corruptions of the input leads to errors. For this, the tests modify the JSON representation of the EvmInput directly.

It checks the following corruptions:

  • modification of a single storage value
  • removing parts of a storage trie
  • modification of an account's balance
  • removing parts of the state trie
  • modification of a single contract's code
  • modification of a header in the ancestor chain
  • modification of the execution block header
  • modification of a single element in the beacon commitment Merkle path

closes #222
closes WEB3-105

@Wollac Wollac requested a review from nategraf September 12, 2024 16:09
@Wollac Wollac self-assigned this Sep 12, 2024
Copy link

linear bot commented Sep 12, 2024

@github-actions github-actions bot changed the title chore: corruption tests for Steel WEB3-105: chore: corruption tests for Steel Sep 12, 2024
@Wollac Wollac marked this pull request as ready for review September 12, 2024 16:21
@Wollac Wollac requested a review from capossele as a code owner September 12, 2024 16:21
Copy link
Contributor

@nategraf nategraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for implementing these

@Wollac Wollac enabled auto-merge (squash) September 12, 2024 22:08
@Wollac Wollac disabled auto-merge September 12, 2024 22:13
@Wollac Wollac enabled auto-merge (squash) September 12, 2024 23:36
@Wollac Wollac merged commit ed5601d into main Sep 12, 2024
10 of 11 checks passed
@Wollac Wollac deleted the chore/corruption-tests branch September 12, 2024 23:37
Wollac added a commit that referenced this pull request Oct 7, 2024
This PR adds tests to ensure that corruptions of the input leads to
errors. For this, the tests modify the JSON representation of the
`EvmInput` directly.

It checks the following corruptions:
- modification of a single storage value
- removing parts of a storage trie
- modification of an account's balance
- removing parts of the state trie
- modification of a single contract's code
- modification of a header in the ancestor chain
- modification of the execution block header
- modification of a single element in the beacon commitment Merkle path

closes #222 
closes WEB3-105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corruption tests for Steel
2 participants